Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PgSQLXML setCharacterStream() results in null value #1608

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@davecramer
Copy link
Member

davecramer commented Nov 14, 2019

fixes Issue #731

@sehrope

This comment has been minimized.

Copy link
Contributor

sehrope commented Nov 14, 2019

@davecramer Need to add this to a suite for it to run.

Also, s/Copyright (c) 2004/Copyright (c) 2019/.

@davecramer

This comment has been minimized.

Copy link
Member Author

davecramer commented Nov 14, 2019

@sehrope I knew that and got distracted :( ADD kicking in

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 14, 2019

@sehrope

This comment has been minimized.

Copy link
Contributor

sehrope commented Nov 14, 2019

@davecramer Well it is a part of the PR checklist template ;-)

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 14, 2019

@davecramer

This comment has been minimized.

Copy link
Member Author

davecramer commented Nov 14, 2019

@sehrope that's what that's for :)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #1608 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1608      +/-   ##
============================================
+ Coverage     68.96%   68.97%   +<.01%     
+ Complexity     4008     4007       -1     
============================================
  Files           179      179              
  Lines         16654    16655       +1     
  Branches       2714     2714              
============================================
+ Hits          11486    11488       +2     
+ Misses         3911     3908       -3     
- Partials       1257     1259       +2
@davecramer davecramer merged commit 1e37026 into pgjdbc:master Nov 15, 2019
3 checks passed
3 checks passed
codecov/project 68.97% (+<.01%) compared to e64b0a2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davecramer davecramer deleted the davecramer:fixpgsqlxml branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.