Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pginterval to take iso8601 strings #1612

Merged
merged 4 commits into from Nov 25, 2019
Merged

Conversation

@davecramer
Copy link
Member

davecramer commented Nov 20, 2019

this is a work in progress looking for comments on how to deal with things like months > 12 should we rationalize this before sending to the backend?

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 20, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #1612 into master will increase coverage by 0.06%.
The diff coverage is 78.26%.

@@             Coverage Diff              @@
##             master    #1612      +/-   ##
============================================
+ Coverage        69%   69.06%   +0.06%     
- Complexity     4010     4040      +30     
============================================
  Files           179      179              
  Lines         16664    16750      +86     
  Branches       2716     2740      +24     
============================================
+ Hits          11499    11569      +70     
- Misses         3907     3916       +9     
- Partials       1258     1265       +7
@RhodiumToad

This comment has been minimized.

Copy link

RhodiumToad commented Nov 20, 2019

No particular reason to normalize interval parts; the backend just stores months,days,microseconds anyway and converts to those.

@davecramer

This comment has been minimized.

Copy link
Member Author

davecramer commented Nov 21, 2019

@RhodiumToad In general I'd like to be able to retrieve what we send. If we have something like 30 months when we get it back it will be different. Not sure that matters, and not sure I want to go to the trouble to make it work. Thanks for your feedback.

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 21, 2019

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 25, 2019

@AppVeyorBot

This comment has been minimized.

Copy link

AppVeyorBot commented Nov 25, 2019

@davecramer davecramer merged commit 7b45435 into pgjdbc:master Nov 25, 2019
3 checks passed
3 checks passed
codecov/project 69.06% (+0.06%) compared to 00fa448
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davecramer davecramer deleted the davecramer:fixinterval branch Nov 25, 2019
@reibitto reibitto mentioned this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.