fix: null pointer exception from PgResultSetMetaData when there's no column metadata #1615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As described in #1613 and a previous PR #663, the driver throws null pointer exception when building the results for queries without column metadata, e.g.
SELECT <x> FROM <table name> <x>
, where<x>
is not a column name but an alias of the table. It should just return the whole table. (There might be other queries that can also reproduce this issue.)However the above PR only fix one place where
field.getMetadata()
is null. There are four more places might cause the NPE.In this minor fix, we return "" as the columnName, schemaName, tableName if the metadata is null, and
ResultSetMetaData.columnNullable
for nullable.All Submissions:
New Feature Submissions:
Changes to Existing Features: