Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DatabaseMetaData.getFunctions should not limit the search to the search_path if the schema is provided #1633

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@davecramer
Copy link
Member

davecramer commented Dec 3, 2019

Currently getFunctions adds pg_function_is_visible to the sql looking for functions in all cases. If the user provides a schema but it is not on the search path no functions will be found. This seems counter-intuitive.

With this PR if the user provides a schema then that schema will be searched. If the schema is empty or null then the search path will be searched for the function.

… search_path if the schema is provided
@davecramer

This comment has been minimized.

Copy link
Member Author

davecramer commented Dec 3, 2019

@sehrope this is an area where you would have quite a bit of feedback I would think?

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1633 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1633      +/-   ##
============================================
+ Coverage     69.02%   69.06%   +0.03%     
- Complexity     4068     4073       +5     
============================================
  Files           181      181              
  Lines         16861    16863       +2     
  Branches       2760     2760              
============================================
+ Hits          11638    11646       +8     
+ Misses         3947     3945       -2     
+ Partials       1276     1272       -4
@davecramer davecramer merged commit 8106d3d into pgjdbc:master Dec 5, 2019
3 checks passed
3 checks passed
codecov/project 69.06% (+0.03%) compared to 97d32ca
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davecramer davecramer deleted the davecramer:fixgetfunctions branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.