Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow binary transfer for those Oids that the pgjdbc currently s… #1637

Conversation

@mahmoudbahaa
Copy link
Contributor

mahmoudbahaa commented Dec 5, 2019

…upports

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
@davecramer

This comment has been minimized.

Copy link
Member

davecramer commented Dec 5, 2019

thanks!

@mahmoudbahaa mahmoudbahaa force-pushed the mahmoudbahaa:only_allow_binary_for_those_actually_supported branch from 9507f51 to 4dda2c8 Dec 5, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 5, 2019

Codecov Report

Merging #1637 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1637      +/-   ##
============================================
+ Coverage     69.06%   69.06%   +<.01%     
+ Complexity     4084     4083       -1     
============================================
  Files           181      181              
  Lines         16886    16890       +4     
  Branches       2771     2771              
============================================
+ Hits          11662    11665       +3     
  Misses         3946     3946              
- Partials       1278     1279       +1
@mahmoudbahaa mahmoudbahaa force-pushed the mahmoudbahaa:only_allow_binary_for_those_actually_supported branch from 4dda2c8 to 724fc9d Dec 6, 2019
@mahmoudbahaa

This comment has been minimized.

Copy link
Contributor Author

mahmoudbahaa commented Dec 6, 2019

@davecramer all checks are now green

…rted
@davecramer davecramer merged commit ad83cb3 into pgjdbc:master Dec 6, 2019
3 checks passed
3 checks passed
codecov/project Absolute coverage decreased by -0.28% but relative coverage increased by +30.89% compared to c85b149
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.