Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case and documentation for calling stored procedures with transaction control. #1645

Merged
merged 1 commit into from Dec 12, 2019

Conversation

draderaws
Copy link
Contributor

@draderaws draderaws commented Dec 10, 2019

Add documentation and unit test for calling stored procedures that use transaction control. Update existing callproc doc to refer to functions and procedures. Add error code returned from server if stored proc with transaction control is called from inside a transaction.

All Submissions:

  • [Yes] Have you followed the guidelines in our Contributing document? Yes
  • [Yes] Have you checked to ensure there aren't other open Pull Requests for the same update/change? Yes
  1. [yes] Does your submission pass tests?
  2. [yes] Does mvn checkstyle:check pass ?
  3. [yes] Have you added your new test classes to an existing test suite in alphabetical order?
  • [no] Does this break existing behaviour? If so please explain.
  • [yes] Have you written new tests for your core changes, as applicable? new test, not core change.
  • [yes] Have you successfully run tests with your changes locally?

@davecramer davecramer merged commit d10ab8d into pgjdbc:master Dec 12, 2019
1 of 2 checks passed
@draderaws draderaws deleted the proctranstest branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants