Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 1482 where the port was being added to the GSSAPI service name #1651

Merged
merged 1 commit into from Dec 17, 2019

Conversation

davecramer
Copy link
Member

@davecramer davecramer commented Dec 17, 2019

PostgreSQL does not use the port in the service name which is consistent with the GSSAPI docs

@codecov-io
Copy link

@codecov-io codecov-io commented Dec 17, 2019

Codecov Report

Merging #1651 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #1651      +/-   ##
===========================================
- Coverage     68.81%   68.8%   -0.01%     
- Complexity     4086    4087       +1     
===========================================
  Files           181     181              
  Lines         16941   16957      +16     
  Branches       2789    2789              
===========================================
+ Hits          11658   11668      +10     
- Misses         4005    4012       +7     
+ Partials       1278    1277       -1

@devanshsoni9
Copy link

@devanshsoni9 devanshsoni9 commented Dec 17, 2019

@davecramer I tested your change with both a remote postgres server and a localhost postgres server. The SSPI auth succeeds in both the cases.

@davecramer davecramer merged commit f7a55cf into pgjdbc:master Dec 17, 2019
2 of 3 checks passed
@davecramer davecramer deleted the fixsspi branch Dec 17, 2019
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants