Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: add caller push of binary data (rebase of #953) #1659
Rebase and fix of #953.
New Feature Submissions:
Changes to Existing Features:
Allows a caller to push binary data to an output stream rather than having to provide a byte array or input stream. This gives the caller more control over buffering strategy and allows explicit cleanup of off-heap buffers or other non-garbage-collected resources.
Nope, looks good, I just want to see if I can get travis green. Either way I will push this later today Thanks again Dave Cramer…
On Mon, 23 Dec 2019 at 14:41, Lőrinc Pap ***@***.***> wrote: Is there anything else you would like us to do here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1659?email_source=notifications&email_token=AADDH5XXAT4KT6LU67YDTU3Q2EH7DA5CNFSM4J6REELKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHRZU2I#issuecomment-568564329>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADDH5S2AXILHMSDLL25LFLQ2EH7DANCNFSM4J6REELA> .
@@ Coverage Diff @@ ## master #1659 +/- ## ============================================ + Coverage 68.79% 68.89% +0.09% - Complexity 4080 4104 +24 ============================================ Files 181 183 +2 Lines 16957 17014 +57 Branches 2789 2794 +5 ============================================ + Hits 11666 11721 +55 - Misses 4011 4015 +4 + Partials 1280 1278 -2
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.