New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix streaming error with a unstable network connection #1681
Conversation
still failing the testAsyncNotifyWithTimeout test |
Codecov Report
@@ Coverage Diff @@
## master #1681 +/- ##
============================================
+ Coverage 69.04% 69.04% +<.01%
- Complexity 4153 4162 +9
============================================
Files 186 186
Lines 17148 17169 +21
Branches 2855 2861 +6
============================================
+ Hits 11839 11855 +16
- Misses 4026 4032 +6
+ Partials 1283 1282 -1 |
@hyunkshinft have you tested this with the streamProblem test ? I'm OK with this as a stop gap measure. The real solution is to read from the backend using a separate thread. |
@davecramer Yes, I did test with streamProblem which ran successfully.
It sounds like a more radical change to overall architecture. I will leave that challenge to more experienced pgjdbc guru like you. |
Thanks ya, it is a bit more invasive. |
* origin/master: (427 commits) refactor: make PSQLState enum consts for integrity constraint violations (pgjdbc#1699) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release REL42.2.10 pass gpg key through arguments add passphrase to release mvn task chore: update signing key Metadata queries improvment (pgjdbc#1694) WIP release notes for 42.2.10 (pgjdbc#1688) chore(deps): bump checkstyle from 8.28 to 8.29 in /pgjdbc (pgjdbc#1691) Cleanup PGProperty, sort values, and add some missing to docs (pgjdbc#1686) fix: Fixes issue pgjdbc#1592 where one thread is reading the copy and another thread closes the connection (pgjdbc#1594) Fixing LocalTime rounding (losing precision) (pgjdbc#1570) sync error message value with tested value (pgjdbc#1664) add DatabaseMetaDataCacheTest to test suite to run it (pgjdbc#1685) Fix Network Performance of PgDatabaseMetaData.getTypeInfo() method (pgjdbc#1668) fix: Issue pgjdbc#1680 updating a boolean field requires special handling to set it to t or f instead of true or false (pgjdbc#1682) fix testSetNetworkTimeoutEnforcement test failure (pgjdbc#1681) minor: fix checkstyle violation of unused import (pgjdbc#1683) fix: pgjdbc#1677 NumberFormatException when fetching PGInterval with small value (pgjdbc#1678) fix: actually use milliseconds instead of microseconds for timeouts (pgjdbc#1653) ...
* fix: bug in pgstream for replication * fix testSetNetworkTimeoutEnforcement test failure. * fix testAsyncNotifyWithTimeout test failure * address checkstyle failure * respect socket timeout setting while the read operation Co-authored-by: Dave Cramer <davecramer@gmail.com>
All Submissions:
New Feature Submissions:
Changes to Existing Features: