Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streaming error with a unstable network connection #1681

Merged
merged 5 commits into from Jan 28, 2020
Merged

fix streaming error with a unstable network connection #1681

merged 5 commits into from Jan 28, 2020

Conversation

hyunkshinft
Copy link
Contributor

@hyunkshinft hyunkshinft commented Jan 27, 2020

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@davecramer
Copy link
Member

@davecramer davecramer commented Jan 27, 2020

still failing the testAsyncNotifyWithTimeout test

@hyunkshinft hyunkshinft requested a review from davecramer Jan 27, 2020
@codecov-io
Copy link

@codecov-io codecov-io commented Jan 27, 2020

Codecov Report

Merging #1681 into master will increase coverage by <.01%.
The diff coverage is 75.86%.

@@             Coverage Diff              @@
##             master    #1681      +/-   ##
============================================
+ Coverage     69.04%   69.04%   +<.01%     
- Complexity     4153     4162       +9     
============================================
  Files           186      186              
  Lines         17148    17169      +21     
  Branches       2855     2861       +6     
============================================
+ Hits          11839    11855      +16     
- Misses         4026     4032       +6     
+ Partials       1283     1282       -1

@hyunkshinft hyunkshinft reopened this Jan 27, 2020
@davecramer
Copy link
Member

@davecramer davecramer commented Jan 28, 2020

@hyunkshinft have you tested this with the streamProblem test ? I'm OK with this as a stop gap measure. The real solution is to read from the backend using a separate thread.

@hyunkshinft
Copy link
Contributor Author

@hyunkshinft hyunkshinft commented Jan 28, 2020

@hyunkshinft have you tested this with the streamProblem test ?

@davecramer Yes, I did test with streamProblem which ran successfully.

The real solution is to read from the backend using a separate thread.

It sounds like a more radical change to overall architecture. I will leave that challenge to more experienced pgjdbc guru like you.

@davecramer
Copy link
Member

@davecramer davecramer commented Jan 28, 2020

Thanks ya, it is a bit more invasive.

@davecramer davecramer merged commit 799e78d into pgjdbc:master Jan 28, 2020
3 checks passed
@hyunkshinft hyunkshinft deleted the fixcopy branch Jan 28, 2020
@hyunkshinft hyunkshinft changed the title fix testSetNetworkTimeoutEnforcement test failure fix streaming error with a unstable network connection Jan 28, 2020
paplorinc added a commit to paplorinc/pgjdbc that referenced this issue Feb 10, 2020
* origin/master: (427 commits)
  refactor: make PSQLState enum consts for integrity constraint violations (pgjdbc#1699)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release REL42.2.10
  pass gpg key through arguments
  add passphrase to release mvn task
  chore: update signing key
  Metadata queries improvment (pgjdbc#1694)
  WIP release notes for 42.2.10 (pgjdbc#1688)
  chore(deps): bump checkstyle from 8.28 to 8.29 in /pgjdbc (pgjdbc#1691)
  Cleanup PGProperty, sort values, and add some missing to docs (pgjdbc#1686)
  fix: Fixes issue pgjdbc#1592 where one thread is reading the copy and another thread closes the connection (pgjdbc#1594)
  Fixing LocalTime rounding (losing precision) (pgjdbc#1570)
  sync error message value with tested value (pgjdbc#1664)
  add DatabaseMetaDataCacheTest to test suite to run it (pgjdbc#1685)
  Fix Network Performance of PgDatabaseMetaData.getTypeInfo() method (pgjdbc#1668)
  fix: Issue pgjdbc#1680 updating a boolean field requires special handling to set it to t or f instead of true or false (pgjdbc#1682)
  fix testSetNetworkTimeoutEnforcement test failure (pgjdbc#1681)
  minor: fix checkstyle violation of unused import (pgjdbc#1683)
  fix: pgjdbc#1677 NumberFormatException when fetching PGInterval with small value (pgjdbc#1678)
  fix: actually use milliseconds instead of microseconds for timeouts (pgjdbc#1653)
  ...
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* fix: bug in pgstream for replication

* fix testSetNetworkTimeoutEnforcement test failure.

* fix testAsyncNotifyWithTimeout test failure

* address checkstyle failure

* respect socket timeout setting while the read operation

Co-authored-by: Dave Cramer <davecramer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants