Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue #1680 updating a boolean field requires special handling to set it to t or f instead of true or false #1682

Merged
merged 2 commits into from Jan 29, 2020

Conversation

davecramer
Copy link
Member

@davecramer davecramer commented Jan 28, 2020

No description provided.

…ling to set it to t or f instead of true or false
@davecramer davecramer changed the title fix: Issue #1680 updating a boolean field requIres special handling to set it to t or f instead of true or false fix: Issue #1680 updating a boolean field requires special handling to set it to t or f instead of true or false Jan 28, 2020
getDefaultCalendar(), (Date) valueObject));
rowBuffer[columnIndex] =
connection.encodeString(connection.getTimestampUtils().toString(getDefaultCalendar(),
(Date) valueObject));
Copy link
Member

@sehrope sehrope Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the DATE handling changed right? If so let's leave it untouched by the PR.

Copy link
Member Author

@davecramer davecramer Jan 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct. will revert. Didn't like the formatting

@codecov-io
Copy link

@codecov-io codecov-io commented Jan 28, 2020

Codecov Report

Merging #1682 into master will increase coverage by 0.25%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1682      +/-   ##
============================================
+ Coverage     69.04%   69.29%   +0.25%     
- Complexity     4153     4263     +110     
============================================
  Files           186      186              
  Lines         17148    17384     +236     
  Branches       2855     2926      +71     
============================================
+ Hits          11839    12046     +207     
- Misses         4026     4043      +17     
- Partials       1283     1295      +12

@davecramer davecramer merged commit c266b08 into pgjdbc:master Jan 29, 2020
3 checks passed
@davecramer davecramer deleted the fixbooleanupdate branch Jan 29, 2020
paplorinc added a commit to paplorinc/pgjdbc that referenced this issue Feb 10, 2020
* origin/master: (427 commits)
  refactor: make PSQLState enum consts for integrity constraint violations (pgjdbc#1699)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release REL42.2.10
  pass gpg key through arguments
  add passphrase to release mvn task
  chore: update signing key
  Metadata queries improvment (pgjdbc#1694)
  WIP release notes for 42.2.10 (pgjdbc#1688)
  chore(deps): bump checkstyle from 8.28 to 8.29 in /pgjdbc (pgjdbc#1691)
  Cleanup PGProperty, sort values, and add some missing to docs (pgjdbc#1686)
  fix: Fixes issue pgjdbc#1592 where one thread is reading the copy and another thread closes the connection (pgjdbc#1594)
  Fixing LocalTime rounding (losing precision) (pgjdbc#1570)
  sync error message value with tested value (pgjdbc#1664)
  add DatabaseMetaDataCacheTest to test suite to run it (pgjdbc#1685)
  Fix Network Performance of PgDatabaseMetaData.getTypeInfo() method (pgjdbc#1668)
  fix: Issue pgjdbc#1680 updating a boolean field requires special handling to set it to t or f instead of true or false (pgjdbc#1682)
  fix testSetNetworkTimeoutEnforcement test failure (pgjdbc#1681)
  minor: fix checkstyle violation of unused import (pgjdbc#1683)
  fix: pgjdbc#1677 NumberFormatException when fetching PGInterval with small value (pgjdbc#1678)
  fix: actually use milliseconds instead of microseconds for timeouts (pgjdbc#1653)
  ...
davecramer added a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
…ling to set it to t or f instead of true or false (pgjdbc#1682)

* fix: Issue pgjdbc#1680 updating a boolean field requries special handling to set it to t or f instead of true or false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants