Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose ByteStreamWriter in CopyManager #1702

Merged
merged 1 commit into from Feb 11, 2020

Conversation

paplorinc
Copy link
Contributor

@paplorinc paplorinc commented Feb 11, 2020

Continuing #953, let's expose the garbageless writer to the COPY protocol as well.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does mvn checkstyle:check pass?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@paplorinc paplorinc requested a review from davecramer Feb 11, 2020
@davecramer
Copy link
Member

@davecramer davecramer commented Feb 11, 2020

looks fine to me. I'll merge this later if nobody has any issues with it

@davecramer davecramer merged commit 1e4f475 into pgjdbc:master Feb 11, 2020
2 checks passed
@paplorinc
Copy link
Contributor Author

@paplorinc paplorinc commented Feb 11, 2020

Thanks for your swift review, Dave!

@paplorinc paplorinc deleted the paplorinc/off-heap-copyIn branch Feb 14, 2020
davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants