Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for full names of data types #1719

Merged
merged 2 commits into from Feb 26, 2020

Conversation

MSGoodman
Copy link
Contributor

@MSGoodman MSGoodman commented Feb 25, 2020

Currently the driver only recognizes alias names (e.g. varchar,
float8, timetz) and not full names (e.g. character varying,
double precision, time with time zone); add support for the full
names of data types.

Closes #1563

All Submissions:

  • [✓] Have you followed the guidelines in our Contributing document?
  • [✓] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Existing Features:

  • [✓] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [✓] Have you written new tests for your core changes, as applicable?
  • [✓] Have you successfully run tests with your changes locally?

Currently the driver only recognizes alias names (e.g. "varchar",
"float8", "timetz") and not full names (e.g. "character varying",
"double precision", "time with time zone"); add support for the full
names of data types.

Closes pgjdbc#1563
@davecramer
Copy link
Member

@davecramer davecramer commented Feb 25, 2020

@MSGoodman thanks! Can you also add the tests for timestamp(tz) as well ?

Thanks

@codecov-io
Copy link

@codecov-io codecov-io commented Feb 26, 2020

Codecov Report

Merging #1719 into master will increase coverage by 0.12%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1719      +/-   ##
============================================
+ Coverage      69.3%   69.43%   +0.12%     
- Complexity     4195     4201       +6     
============================================
  Files           187      187              
  Lines         17265    17276      +11     
  Branches       2870     2871       +1     
============================================
+ Hits          11966    11995      +29     
+ Misses         4015     3996      -19     
- Partials       1284     1285       +1

@davecramer davecramer merged commit f554118 into pgjdbc:master Feb 26, 2020
3 checks passed
davecramer added a commit that referenced this issue Mar 30, 2020
vlsi added a commit that referenced this issue Mar 30, 2020
davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* fix: add support for full names of data types

Currently the driver only recognizes alias names (e.g. "varchar",
"float8", "timetz") and not full names (e.g. "character varying",
"double precision", "time with time zone"); add support for the full
names of data types.

Closes pgjdbc#1563

* fix: add timestamp with timezone to full data type name array test
davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants