Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade maven-checkstyle-plugin to 3.1.1 #1726

Merged
merged 1 commit into from Mar 4, 2020

Conversation

nick-mancuso
Copy link
Contributor

@nick-mancuso nick-mancuso commented Mar 3, 2020

perf: upgrade maven-checkstyle-plugin to 3.1.1

upgrade maven-checkstyle-plugin to newest version

upgrade maven-checkstyle-plugin to newest version
@nick-mancuso nick-mancuso changed the title perf: upgrade maven-checkstyle-plugin to 3.1.1 upgrade maven-checkstyle-plugin to 3.1.1 Mar 3, 2020
@romani
Copy link
Contributor

@romani romani commented Mar 4, 2020

@vlsi , please look at this PR, this update is required for us(checksyle organization) to proceed with API cleanup.
It is safe to update, you can see referenced PRs, and discussion with plugin maintainers.

@vlsi vlsi merged commit 7da6007 into pgjdbc:master Mar 4, 2020
2 checks passed
@vlsi
Copy link
Member

@vlsi vlsi commented Mar 4, 2020

@romani, thanks.

By the way: pgjdbc is going to switch from Maven to Gradle shortly (~in a week or two).
You can see the relevant PR in #1627

Technically speaking, you should still be able to execute Checkstyle verifications by running ./gradlew checkstyleAll -PenableMavenLocal -Pcheckstyle.version=...

Does that work for you?

@romani
Copy link
Contributor

@romani romani commented Mar 4, 2020

Yes it works, we can execute any command line

@romani
Copy link
Contributor

@romani romani commented Mar 4, 2020

@vlsi , it would be super awesome if you send us PR, ones you be ready to merge.
You need to change https://github.com/checkstyle/checkstyle/blob/master/.ci/wercker.sh#L57 it will help avoid numerous failures in PRs

davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
upgrade maven-checkstyle-plugin to newest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants