Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated openssl example command #1763

Merged

Conversation

bvanderveen
Copy link
Contributor

@bvanderveen bvanderveen commented Apr 23, 2020

This updates the documentation about how to connect using SSL and the key format requirements.

  • reflect the filenames the user likely needs
  • adds -nocrypt flag to prevent driver from attempting to ask the user for a password

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

update openssl example command to reflect the filenames the user likely needs, and to be
consistent with the naming requirements described in the previous sentence. add -nocrypt flag to
the example command. this prevents driver from attempting to ask the user for a password for the
resulting key file (even when the input key did not have a password).
@bvanderveen
Copy link
Contributor Author

bvanderveen commented Apr 23, 2020

This is in reference to: #1364 (comment)

@davecramer
Copy link
Member

davecramer commented Apr 23, 2020

You do not need the -nocrypt if you provide an sslpwd. I'll push yours if you can update that bit.

@bvanderveen
Copy link
Contributor Author

bvanderveen commented Apr 23, 2020

I propose a note just below the command like:

If your key has a password, provide it using the sslpassword connection parameter described below. Otherwise, you can add the flag -nocrypt to the above command to prevent the driver from requesting a password.

If that sounds good I have a commit standing by.

@davecramer
Copy link
Member

davecramer commented Apr 23, 2020

Seems reasonable enough.

Explain that key passwords are provided using sslpassword. Move the mention of the `-nocrypt`
flag to the note for use with password-less key files.
@bvanderveen
Copy link
Contributor Author

bvanderveen commented Apr 23, 2020

Done, thanks for your effort and support!

@davecramer davecramer merged commit e19d458 into pgjdbc:master Apr 23, 2020
3 of 4 checks passed
davecramer pushed a commit to davecramer/pgjdbc that referenced this pull request Jul 5, 2021
* docs: update openssl key conversion example command

update openssl example command to reflect the filenames the user likely needs, and to be
consistent with the naming requirements described in the previous sentence. add -nocrypt flag to
the example command. this prevents driver from attempting to ask the user for a password for the
resulting key file (even when the input key did not have a password).

* docs: add note explaining usage of sslpassword with respect to sslkey

Explain that key passwords are provided using sslpassword. Move the mention of the `-nocrypt`
flag to the note for use with password-less key files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants