Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some changelog formatting and add link to XXE fix #1794

Merged
merged 2 commits into from Jun 9, 2020

Conversation

sehrope
Copy link
Member

@sehrope sehrope commented Jun 6, 2020

This updates the latest changelog entry to clean up some formatting and add links to the fix commit in the latest changelog entry. The other commit also fixes a missing bold heading on an older entry.

Related, would have been nice if the merge commit for the fix had a better title. Seeing "Merge pull request from GHSA-37xm-4h3m-5w3v" isn't particularly descriptive when you're scanning commit headings.

Not worth rewriting history for it, but going forward would be good to either rebase and add the actual commits for PRs (if they're individually relevant) or manually update merge titles so they reflect something meaningful at merge time (if they're a bunch of commits that only make sense in tandem).

@davecramer davecramer merged commit 98a9bdc into pgjdbc:master Jun 9, 2020
2 of 4 checks passed
davecramer pushed a commit to davecramer/pgjdbc that referenced this issue Jul 5, 2021
* fix: Correct markdown formatting for heading

* docs: Reformat changelog and add link to XXE fix commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants