Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improved support for BLOBs #219
Added the support for very large objects (4TB) when backend is at least 9.3 using lo_xxx64 functions (see release 9.3 notes).
Added support for various JDBC4 methods related to Blobs:
BTW, changed junit dependency to 4.11 to get assertArrayEquals
I've just found out that since the origin, junit tests using blobs were not deleting them at the end! I've just added 227bddd in this PR to fix it.
Those who often run the tests may want to reclaim some wasted blob space in the database used for testing purposes...
This looks pretty sane at a quick read.
My only concern is with the fastpath API changes. The PgJDBC ffastpath support is public API that corresponds to PostgreSQL server backend functionality clients may use directly. I don't think it's appropriate to just change the return type. Why is that necessary?
BTW, I really appreciate that you're adding appropriate tests with these patches.
Right. I did not understand why fastpath() tries to do a conversion instead of leaving getInteger() do the job. I didn't took care enough of it being a public API before doing the change.
I propose to do the following
Anyway the javadoc was wrong because the third arg was still mentionned.
On 12/02/2014 04:57 AM, Alexis Meneses wrote:
That sounds reasonable.
I doubt we have many real-world users of the fastpath API, but I'd still
The fact that this change didn't break any regression tests shows that
Craig Ringer http://www.2ndQuadrant.com/