New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for setStringType in DataSource #221

Merged
merged 1 commit into from Dec 1, 2014

Conversation

Projects
None yet
3 participants
@alexismeneses
Contributor

alexismeneses commented Nov 24, 2014

Integration of fix #192 submitted by @einavitamar

In a more general way, I think we should use a class of constants grouping all supported driver properties instead of leaving strings a bit everywhere in the code where this kind of mistake is possible.
Making this change can introduce big diff between master and older branches but with the upcoming release of 9.4, we may have less need to backpatch, thus reducing the impact.
Any advice before I possibly work on that?

@davecramer

This comment has been minimized.

Member

davecramer commented Nov 24, 2014

This seems like a worthwhile goal. I'd say go for it and it won't get backpatched into 9.3

ringerc added a commit that referenced this pull request Dec 1, 2014

Merge pull request #221 from alexismeneses/ISSUE_192
Fix for setStringType in DataSource

@ringerc ringerc merged commit 9850824 into pgjdbc:master Dec 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ringerc

This comment has been minimized.

Member

ringerc commented Dec 1, 2014

There's a growing diff between 9.3 and 9.4, such that I see the 9.3 driver as the end of a "legacy" driver series, and the 9.4 driver as the beginning of a driver that'll hopefully get progressively cleaned, trimmed down and have cruft removed. I'm not immensely concerned about backpatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment