Fix for setStringType in DataSource #221
Merged
Conversation
|
This seems like a worthwhile goal. I'd say go for it and it won't get backpatched into 9.3 |
ringerc
added a commit
that referenced
this pull request
Dec 1, 2014
Fix for setStringType in DataSource
|
There's a growing diff between 9.3 and 9.4, such that I see the 9.3 driver as the end of a "legacy" driver series, and the 9.4 driver as the beginning of a driver that'll hopefully get progressively cleaned, trimmed down and have cruft removed. I'm not immensely concerned about backpatches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Integration of fix #192 submitted by @einavitamar
In a more general way, I think we should use a class of constants grouping all supported driver properties instead of leaving strings a bit everywhere in the code where this kind of mistake is possible.
Making this change can introduce big diff between master and older branches but with the upcoming release of 9.4, we may have less need to backpatch, thus reducing the impact.
Any advice before I possibly work on that?