Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Replace StringBuffer with StringBuilder #243
Take advantage of Java 5 using StringBuilder where applicable
First off I think this is awesome. I've been thinking about this every time I poke through the code. Nice to see someone got around to it.
I don't see a point to maintaining two copies of the public methods. They may be public, but they're still internal to the driver. The only true public API of the driver is the core JDBC API and the extensions available via casting to PGConnection (ex: the CopyManager API).
Nobody should be using the "internal" public methods (ex: the Utils class) and, if they are, it'd be their responsibility to update their code to use a StringBuilder instead. I say this as someone who has used those internal helper functions in the past.
This is especially true if it'll be done as a new major release of the driver. Users that are upgrading to a 9.4 (or I guess 9.5?) driver can be expected to compile/test it with their app. It'll immediately be apparent what they need to fix.
Ya, I see no reason to keep the old methods around.
On 5 January 2015 at 21:24, Sehrope Sarkuni firstname.lastname@example.org