perf: improve performance of PgResultSet getByte/getShort/getInt/getLong for float-typed columns #2634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
When we call
PgResultSet.getInt
for float-typed columns fast number parser (getFastInt
) fails on dot symbol and then we go to very slow path: Integer.parseInt throw new NumberFormatException (with stacktrace) that immediately swallowed and finally we parse integer through BigDecimal/BigInteger.I propose to not fail fast parsing or fraction part but just discard it.
All Submissions:
Changes to Existing Features: