Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert change to PGProperty.get() to keep the API consistent #2644

Merged
merged 1 commit into from
Oct 19, 2022
Merged

revert change to PGProperty.get() to keep the API consistent #2644

merged 1 commit into from
Oct 19, 2022

Conversation

davecramer
Copy link
Member

No description provided.

@davecramer davecramer requested a review from vlsi October 18, 2022 19:25
@MarekUniq MarekUniq mentioned this pull request Oct 19, 2022
Merged
2 tasks
vlsi
vlsi reviewed Oct 19, 2022
View reviewed changes
pgjdbc/src/main/java/org/postgresql/PGProperty.java Outdated
}

/**
* Returns the value of the connection parameter from the given {@code Properties} or null if there
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Returns the value of the connection parameter from the given {@code Properties} or null if there
* Returns the value of the connection parameter from the given {@link Properties} or {@code null} if there

vlsi
vlsi reviewed Oct 19, 2022
View reviewed changes
pgjdbc/src/main/java/org/postgresql/PGProperty.java Outdated
@@ -851,7 +851,7 @@ public String getDescription() {
}

/**
* Returns the value of the connection parameters according to the given {@code Properties} or the
* Returns the value of the connection parameter from the given {@code Properties} or the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Returns the value of the connection parameter from the given {@code Properties} or the
* Returns the value of the connection parameter from the given {@link Properties} or the

vlsi
vlsi reviewed Oct 19, 2022
View reviewed changes
pgjdbc/src/main/java/org/postgresql/PGProperty.java Outdated
@@ -862,12 +862,24 @@ public String getDescription() {
}

/**
* Returns the value of the connection parameters according to the given {@code Properties}
*
* Returns the value of the connection parameter from the given {@code Properties} or the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Returns the value of the connection parameter from the given {@code Properties} or the
* Returns the value of the connection parameter from the given {@link Properties} or the

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so if we change that one we should change all of them in the file

vlsi
vlsi approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@vlsi vlsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It would be nice if the PR could be merged as a single commit (or two commits: "restore .get", and "fix code->link")

@davecramer
revert change to PGProperty.get() to keep the API the same
c50a9cf 
delegate get(properties) to getOrDefault, added getOrNull

fix failing ArrayTest for versions below 9.1

change @code to @link for class names
@davecramer
Copy link
Member Author

strangely matrix.exclude( row => row.query_mode == 'simple' && isLessThan(row.pg_version, '9.1')); is not doing what I expected ?

@davecramer davecramer merged commit 9f90de9 into pgjdbc:master Oct 19, 2022
@vlsi
Copy link
Member

vlsi commented Oct 19, 2022

I guess it should be row.query_mode.value == 'simple'

@davecramer
Copy link
Member Author

ah, that makes more sense, thx

@MarekUniq MarekUniq mentioned this pull request Oct 20, 2022
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlsi vlsi vlsi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davecramer @vlsi