Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: Improve type detection with casing issues. #404
Instead of lowercasing typename which causes problems for types which require quote due to non lowercase casing, lowercase on failed alias check and during type lookup for types without schema or quote.
Improve the quote casing heuristics by checking for quote char.
Current rules for casing
type => "type"
This change introduces breaking change. Previously casing was not changed.
So if you had type: CREATE TYPE "TIMESTAMPTZ"(at timestamp, offset int)
Fixes issue with: f1a5cc4 which would interpret "Ns"."Type" as "ns"."type"
Of course I know Postgres defaults to lowercase ;)
I think its bad idea for two reasons:
So it should be either
TYPE => "TYPE"
Oracle behaves the second way, at least in .NET driver (without the support for quotes)
btw. I don't mind the lowercasing (thats fine with me) I mind inconsistency... So we should also convert
I've repushed my changes to make it consistent now.
This is still a breaking change, but I doubt people will run into the BC.
Can you put that in a short summary? (e.g. for the release notes)
I do not find tests that cover that behavior.