fix:Do not set the loglevel when instantiating a connection it is set…

[davecramer]

… when the Driver starts

[davecramer]

This fixes a problem where Driver.setLogLevel has no effect as the property over rides the value. One thing it does change is that it doesn't automatically set the LogWriter to stdout. Suggestions on how/if to handle this ?

[whitingjr]

Removing this line causes all debug logging to be turned off when using a DataSource. This makes low level debugging far more difficult.
What is being fixed by this line being removed ?

[davecramer]

Ah, right, now I recall. If you do something like org.postgresql.Driver.setLogLevel. this line reverts that change unless you have the property externally set as per your DataSource configuration

[davecramer]

Interesting catch-22 it caused debugging to be turned off when not using a DataSource

[whitingjr]

hmm yes interesting.
The default log level of 0 is loaded . If the default were to be null the connectionLogLevel reference would be null. Making programmatic and properties bundle loading compatible.
Ideally a default value of 0 should be loaded as a last resort. Making property setting precedence:

1. Datasource property, 2) Programmatic, 3) Default value
   Do you agree ?

[davecramer]

Yes, that would work for me

[whitingjr]

Ok I'll create an issue #436 and a PR. We can see what you think of the proposed changes.

[whitingjr]

with this line removed the DriverManager.logWriter object is always null. which disables info/debug logging.
Did you intend to replace this line with something else to set up logging ?