New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore clobbered translations (cs, de, fr, it) #409

Merged
merged 2 commits into from Oct 26, 2015

Conversation

Projects
None yet
2 participants
@jcflack
Contributor

jcflack commented Oct 25, 2015

This should close #408.

I notice there is an open #348 to make update-translations.sh be automatically run (contrary to the maintainer instructions on the translations page). I wonder if the project has escaped embarrassment in international quarters exactly because that didn't happen in 2013 when these files got clobbered....

jcflack added some commits Oct 25, 2015

fix: recover cs, de, fr, it translations
These four translations were clobbered in commit 86c0db2 when the
contributor apparently opened these iso-8859-1 and -2 files in a
utf-8 editor to make three small changes, the editor changed all
the non-ascii characters to REPLACEMENT CHARACTER everywhere, and
the files were saved and committed that way. This change just reverts
86c0db2, leaving the three small spelling changes to be reapplied.
fix: redo spelling changes in unclobbered .po
Re-apply the original spelling changes after recovering the cs, de, fr,
and it translations from the commit that clobbered them.

Closes #408.
@jcflack

This comment has been minimized.

Contributor

jcflack commented Oct 26, 2015

Yup ... the .class files all still have their old unclobbered contents (and the old uncorrected spelling occured in three places, so they won't find the translations for those 3 messages).

So somebody ought to run update-translations.sh at some point and commit the updated .class files.

According to msgfmt, though, there's one fatal error in the Japanese translation: a string that has a format element {0} in the original doesn't have it in the translation. I don't read Japanese so I can't tell where the {0} should go.

@davecramer

This comment has been minimized.

Member

davecramer commented Oct 26, 2015

The spelling error wasn't a huge deal... ;) But I will run it.

Dave Cramer

On 25 October 2015 at 20:13, Chapman Flack notifications@github.com wrote:

Yup ... the .class files all still have their old unclobbered contents
(and the old uncorrected spelling occured in three places, so they won't
find the translations for those 3 messages).

So somebody ought to run update-translations.sh at some point and commit
the updated .class files.

According to msgfmt, though, there's one fatal error in the Japanese
translation: a string that has a format element {0} in the original
doesn't have it in the translation. I don't read Japanese so I can't tell
where the {0} should go.


Reply to this email directly or view it on GitHub
#409 (comment).

@jcflack

This comment has been minimized.

Contributor

jcflack commented Oct 26, 2015

The spelling itself could not be a big deal, but with the spelling fixed in the driver code but the messages_*.class files not updated, those three messages won't match when looked up, so I think they'll be output in English instead of in translation. (Affecting all 15 translations, not just the 4 that got zonked.)

Which might also not be such a big deal, but might surprise somebody....

davecramer added a commit that referenced this pull request Oct 26, 2015

Merge pull request #409 from jcflack/master
fix: restore clobbered translations (cs, de, fr, it)

@davecramer davecramer merged commit e66b085 into pgjdbc:master Oct 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment