New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use socket factory #457

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Albatarm

Albatarm commented Dec 16, 2015

Use a socket factory instead of creating socket to let using custom socket like unix sockets...

mtran and others added some commits Oct 12, 2015

@vlsi

This comment has been minimized.

Member

vlsi commented Dec 26, 2015

@Albatarm , do not "merge remote-tracking branch" when preparing pull requests. Use commit --amend or git rebase --interactive to avoid clutter in the git history.

@vlsi vlsi closed this in dc1844c Dec 26, 2015

@vlsi

This comment has been minimized.

Member

vlsi commented Dec 26, 2015

@Albatarm , can you please prepare a pull request with documentation update of https://github.com/pgjdbc/www/blob/master/documentation/head/connect.md ?

/**
* The String argument to give to the constructor of the Socket Factory
*/
SOCKET_FACTORY_ARG("socketFactoryArg", null, "Argument forwarded to constructor of SocketFactory class."),

This comment has been minimized.

@vlsi

vlsi Aug 13, 2018

Member

@Albatarm , could you please clarify why that was needed?

Apparently, socketFactory receives the whole Properties object.
Why pollute public API with socketFactoryArg?

This comment has been minimized.

@Albatarm

Albatarm Sep 11, 2018

I just copied the form of SSL_FACTORY and SSL_FACTORY_ARG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment