docs: Fix typos

[marschall]

Fix a few typos in the comments.

[davecramer]

Believe it or not I think occurred was fixed once already ;)

Dave Cramer

On 28 December 2015 at 07:14, Philippe Marschall notifications@github.com
wrote:

Fix a few typos in the comments.

You can view, comment on, or merge this pull request online at:

#472
Commit Summary

• docs: Fix typos

File Changes

• M pgjdbc/src/main/java/org/postgresql/core/ResultHandler.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-0 (2)
• M
  pgjdbc/src/main/java/org/postgresql/core/v2/ConnectionFactoryImpl.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-1 (2)
• M
  pgjdbc/src/main/java/org/postgresql/core/v3/ConnectionFactoryImpl.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-2 (2)
• M pgjdbc/src/main/java/org/postgresql/ds/PGPoolingDataSource.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-3 (2)
• M pgjdbc/src/main/java/org/postgresql/fastpath/Fastpath.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-4 (2)
• M pgjdbc/src/main/java/org/postgresql/jdbc/PgArray.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-5 (2)
• M pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-6 (2)
• M pgjdbc/src/main/java/org/postgresql/jdbc/PgDatabaseMetaData.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-7 (18)
• M pgjdbc/src/main/java/org/postgresql/jdbc/PgStatement.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-8 (10)
• M pgjdbc/src/main/java/org/postgresql/jdbc/TypeInfoCache.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-9 (2)
• M pgjdbc/src/main/java/org/postgresql/largeobject/LargeObject.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-10 (2)
• M pgjdbc/src/test/java/org/postgresql/test/jdbc2/StatementTest.java
  https://github.com/pgjdbc/pgjdbc/pull/472/files#diff-11 (2)

Patch Links:

• https://github.com/pgjdbc/pgjdbc/pull/472.patch
• https://github.com/pgjdbc/pgjdbc/pull/472.diff

—
Reply to this email directly or view it on GitHub
#472.

[vlsi]

Can we add a checkstyle rule to catch those kind of things?
@marschall , would you please do that?

[marschall]

@vlsi a rule for what? spell checking or just "occured"?

[vlsi]

Well, if you would be able to configure a spellchecker, that would be good.
Otherwise just a couple of well-known "occurencies" might do in checkstyle config.

[davecramer]

How do spell checkers work with variables ? Does it only check spelling in
comments ?

Dave Cramer

On 28 December 2015 at 07:46, Vladimir Sitnikov notifications@github.com
wrote:

Well, if you would be able to configure a spellchecker, that would be good.
Otherwise just a couple of well-known "occurencies" might do in checkstyle
config.

—
Reply to this email directly or view it on GitHub
#472 (comment).

[vlsi]

How do spell checkers work with variables ? Does it only check spelling in
comments ?

It is somewhat hard to google for "spell checker for java sources".

However the following might be feasible:

1. Our JRE8 build produces javadocs. We might spell-check those docs which are HTMLs.
   or
2. pre-process all the sources, leaving just comments, then spell-check the result.

[marschall]

One problem with general spell checkers is that there are a lot of technical terms like "sql" in the source that are often not recognized. As for checkstyle the only option short of writing a custom module would be to use the Regexp module to search for known offenders. Let me know if I should do this. Anything more complex should IMO be moved to a different issue. One issue with just checking the Javadoc output is that about half the typos were in non-Javadoc comments.

[vlsi]

Ok, let's start with listing common offenders in checkstyle configuration.

[davecramer]

This is pretty low priority...IMHO

Dave Cramer

On 28 December 2015 at 08:32, Philippe Marschall notifications@github.com
wrote:

One problem with general spell checkers is that there are a lot of
technical terms like "sql" in the source that are often not recognized. As
for checkstyle the only option short of writing a custom module would be to
use the Regexp http://checkstyle.sourceforge.net/config_regexp.html
module to search for known offenders. Let me know if I should do this.
Anything more complex should IMO be moved to a different issue. One issue
with just checking the Javadoc output is that about half the typos were in
non-Javadoc comments.

—
Reply to this email directly or view it on GitHub
#472 (comment).