fix: toString on PgArray returns null

[davecramer]

calling toString on an array created from a binary connection returned null

[codecov-io]

Current coverage is 56.71%

Merging #504 into master will decrease coverage by -0.03% as of 3810d78

@@            master    #504   diff @@
======================================
  Files          143     143       
  Stmts        15060   15066     +6
  Branches      2950    2951     +1
  Methods          0       0       
======================================
- Hit           8546    8544     -2
- Partial       1172    1174     +2
- Missed        5342    5348     +6

Review entire Coverage Diff as of 3810d78

Powered by Codecov. Updated on successful CI builds.

[vlsi]

@davecramer , it looks like array.toString is a great can of worms.
I've cleaned up a bit in #506

Can you elaborate why do you expect square brackets?
PostgreSQL style for arrays is curly braces.

Note: it is better to place the test in "parent" class, and make sure the test is executed in both binary and non-binary modes.
Otherwise we get different results in different cases.

[davecramer]

@visi,

Well I was torn between returning a "java" array representation and a
postgres representation.
I think the decision to show a postgres representation is fine. The
original complaint was that it threw an NPE.

Thanks

Dave Cramer

On 7 February 2016 at 07:08, Vladimir Sitnikov notifications@github.com
wrote:

@davecramer https://github.com/davecramer , it looks like array.toString
is a great can of worms.
I've cleaned up a bit in #506 #506

Can you elaborate why do you expect square brackets?
PostgreSQL style for arrays is curly braces.

Note: it is better to place the test in "parent" class, and make sure the
test is executed in both binary and non-binary modes.
Otherwise we get different results in different cases.

—
Reply to this email directly or view it on GitHub
#504 (comment).