New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove pgTypeName null check #525

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@marschall
Contributor

marschall commented Mar 1, 2016

There is a null check for the pgTypeName parameter at the end of
TypeInfoCache.getSQLType(String). However at the start of this method
pgTypeName.endsWith("[]") is called. pgTypeName is never assigned. If
follows that pgTypeName can never be null at the end of the method.

refactor: Remove pgTypeName null check
There is a null check for the pgTypeName parameter at the end of
TypeInfoCache.getSQLType(String). However at the start of this method
pgTypeName.endsWith("[]") is called. pgTypeName is never assigned. If
follows that pgTypeName can never be null at the end of the method.
@codecov-io

This comment has been minimized.

codecov-io commented Mar 1, 2016

Current coverage is 57.48%

Merging #525 into master will not affect coverage as of 20e87ed

@@            master    #525   diff @@
======================================
  Files          143     143       
  Stmts        15128   15127     -1
  Branches      2966    2965     -1
  Methods          0       0       
======================================
  Hit           8696    8696       
+ Partial       1176    1175     -1
  Missed        5256    5256       

Review entire Coverage Diff as of 20e87ed

Powered by Codecov. Updated on successful CI builds.

@vlsi vlsi closed this in 462928b Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment