New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support `java.sql.Types.TIME_WITH_TIMEZONE` and `java.sql.Types.TIMESTAMP_WITH_TIMEZONE` #570

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@tminglei
Contributor

tminglei commented May 18, 2016

Support java.sql.Types.TIME_WITH_TIMEZONE and java.sql.Types.TIMESTAMP_WITH_TIMEZONE in setNull method of PgPreparedStatement.

Pls check, and any question pls let me know.

Thanks!

@codecov-io

This comment has been minimized.

codecov-io commented May 18, 2016

Current coverage is 69.47%

Merging #570 into master will decrease coverage by 1.01%

  1. 4 files (not in diff) in ...va/org/postgresql/xa were modified. more
    • Misses +94
    • Hits -105
  2. 8 files (not in diff) in .../org/postgresql/util were modified. more
    • Misses +62
    • Hits -68
  3. 2 files (not in diff) in .../org/postgresql/sspi were modified. more
    • Misses -2
  4. 2 files (not in diff) in ...postgresql/ssl/jdbc4 were modified. more
    • Misses -12
    • Hits -2
  5. 3 files (not in diff) in ...a/org/postgresql/ssl were modified. more
    • Misses -13
  6. 2 files (not in diff) in .../org/postgresql/osgi were modified. more
    • Misses -1
    • Hits -4
  7. 14 files (not in diff) in .../org/postgresql/jdbc were modified. more
    • Misses -80
    • Hits -193
  8. 3 files (not in diff) in ...postgresql/geometric were modified. more
    • Misses +28
    • Hits -32
  9. 2 files (not in diff) in ...postgresql/ds/common were modified. more
    • Misses -1
    • Hits -6
  10. 2 files (not in diff) in ...va/org/postgresql/ds were modified. more
    • Misses -1
    • Hits -6
@@             master       #570   diff @@
==========================================
  Files           146        147     +1   
  Lines         15500      14930   -570   
  Methods           0          0          
  Messages          0          0          
  Branches       3064       2967    -97   
==========================================
- Hits          10925      10372   -553   
+ Misses         4575       4558    -17   
  Partials          0          0          

Powered by Codecov. Last updated by fb2977f...ea50d9c

@vlsi

This comment has been minimized.

Member

vlsi commented May 18, 2016

@tminglei , can you please add some tests as well?

tminglei added some commits May 22, 2016

@tminglei

This comment has been minimized.

Contributor

tminglei commented May 22, 2016

@vlsi added, pls check again.

@vlsi

This comment has been minimized.

Member

vlsi commented May 22, 2016

@tminglei , please add the new test class to a jdbc42 test suite: https://github.com/pgjdbc/pgjdbc/blob/f3b0fd007ca2fc186626c4ee5157015932c4a359/pgjdbc/src/test/java/org/postgresql/test/jdbc42/Jdbc42TestSuite.java

Just for you information: it's better to follow single assertion per test method approach. jdbc42/PreparedStatementTest.java is small, so we can refactor it later if needed. In more involved cases it makes sense to have multiple test methods or even @Parameterized ones

@tminglei

This comment has been minimized.

Contributor

tminglei commented May 23, 2016

done, pls check again.

@vlsi vlsi closed this in 1b73bf6 May 23, 2016

@vlsi

This comment has been minimized.

Member

vlsi commented May 23, 2016

@tminglei , thank you for the contribution

zemian pushed a commit to zemian/pgjdbc that referenced this pull request Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment