New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fail during parsin 10devel version #631

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Gordiychuk
Contributor

Gordiychuk commented Aug 21, 2016

Number of HEAD postgresql is 10devel postgres/postgres@ca9112a
but ServerVersion parse it as 0.

This commit fix few tests that base on version for #630

@Gordiychuk Gordiychuk force-pushed the Gordiychuk:10devel branch 3 times, most recently from d792275 to 3001ec5 Aug 21, 2016

bug: fail during parsin 10devel version
Number of HEAD postgresql is 10devel
postgres/postgres@ca9112a
but ServerVersion parse it as 0.

This commit fix few tests that base on version for #630
@codecov-io

This comment has been minimized.

codecov-io commented Aug 21, 2016

Current coverage is 61.91% (diff: 100%)

Merging #631 into master will increase coverage by 0.02%

@@             master       #631   diff @@
==========================================
  Files           150        150          
  Lines         15159      15160     +1   
  Methods           0          0          
  Messages          0          0          
  Branches       3050       3050          
==========================================
+ Hits           9382       9387     +5   
+ Misses         4523       4518     -5   
- Partials       1254       1255     +1   

Powered by Codecov. Last update 07c7902...3001ec5

@vlsi vlsi closed this in 89fe182 Aug 28, 2016

vlsi added a commit that referenced this pull request Aug 28, 2016

feat: support 10+ version parsing
Note:
  10.2 means 10 major, 2 minor, that is 10_00_02
  9.2 means 9.2 major, that is 9_02_00

It is assumed that versions would be 10head -> 10 -> 10.1head -> ...
postgres/postgres@ca9112a

Relevant libpq parsing logic: postgres/postgres@69dc5ae

closes #631

vlsi added a commit that referenced this pull request Aug 28, 2016

feat: support 10+ version parsing
Note:
  10.2 means 10 major, 2 minor, that is 10_00_02
  9.2 means 9.2 major, that is 9_02_00

It is assumed that versions would be 10head -> 10 -> 10.1head -> ...
postgres/postgres@ca9112a

Relevant libpq parsing logic: postgres/postgres@69dc5ae

closes #631

zemian pushed a commit to zemian/pgjdbc that referenced this pull request Oct 6, 2016

feat: support 10+ version parsing
Note:
  10.2 means 10 major, 2 minor, that is 10_00_02
  9.2 means 9.2 major, that is 9_02_00

It is assumed that versions would be 10head -> 10 -> 10.1head -> ...
postgres/postgres@ca9112a

Relevant libpq parsing logic: postgres/postgres@69dc5ae

closes pgjdbc#631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment