Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make HostChooser implement Iterable #645

Closed
wants to merge 3 commits into from

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Sep 25, 2016

make HostChooser implement Iterable. Also refactoring of usage of Iterators

AlexElin added 2 commits Sep 25, 2016
 make HostChooser implement Iterable. Also refactoring of usage of Iterators
fix compilation error on jdk 6,7
@codecov-io
Copy link

@codecov-io codecov-io commented Sep 25, 2016

Current coverage is 61.91% (diff: 92.85%)

Merging #645 into master will decrease coverage by 0.03%

@@             master       #645   diff @@
==========================================
  Files           150        150          
  Lines         15164      15142    -22   
  Methods           0          0          
  Messages          0          0          
  Branches       3051       3046     -5   
==========================================
- Hits           9394       9375    -19   
+ Misses         4518       4516     -2   
+ Partials       1252       1251     -1   

Powered by Codecov. Last update 08e1a40...1b39cbc

Copy link
Member

@vlsi vlsi left a comment

+1 in general, however I think it makes sense to use .toArray(new String[0]) for Collection->String[] conversion

while (e.hasNext()) {
types[i++] = e.next();
for (String s : tableTypeClauses.keySet()) {
types[i++] = s;

This comment has been minimized.

@vlsi

vlsi Oct 5, 2016
Member

Would you please convert to tableTypeClauses.keySet().toArray(new String[0]) here?

This comment has been minimized.

@AlexElin

AlexElin Oct 5, 2016
Author Contributor

made conversion

while (e.hasNext()) {
permNames[i++] = e.next();
for (String s : permissions.keySet()) {
permNames[i++] = s;

This comment has been minimized.

@vlsi

vlsi Oct 5, 2016
Member

keySet().toArray(...)?

This comment has been minimized.

@AlexElin

AlexElin Oct 5, 2016
Author Contributor

made conversion

while (g.hasNext()) {
granteeUsers[k++] = g.next();
for (String s : grantees.keySet()) {
granteeUsers[k++] = s;

This comment has been minimized.

@vlsi

vlsi Oct 5, 2016
Member

grantees.keySet().toArray(...)?

This comment has been minimized.

@AlexElin

AlexElin Oct 5, 2016
Author Contributor

made conversion

while (e.hasNext()) {
permNames[i++] = e.next();
for (String s : permissions.keySet()) {
permNames[i++] = s;

This comment has been minimized.

@vlsi

vlsi Oct 5, 2016
Member

keySet().toArray(...)?

This comment has been minimized.

@AlexElin

AlexElin Oct 5, 2016
Author Contributor

made conversion

while (g.hasNext()) {
granteeUsers[k++] = g.next();
for (String s : grantees.keySet()) {
granteeUsers[k++] = s;

This comment has been minimized.

@vlsi

vlsi Oct 5, 2016
Member

grantees.keySet().toArray(...)?

This comment has been minimized.

@AlexElin

AlexElin Oct 5, 2016
Author Contributor

made conversion

use .toArray(new String[0]) for Collection->String[] conversion
@davecramer
Copy link
Member

@davecramer davecramer commented Oct 27, 2016

@vlsi are you OK with this now ?

@vlsi vlsi force-pushed the pgjdbc:master branch 2 times, most recently from c8cebf6 to f52bf7f Oct 29, 2016
@vlsi vlsi added this to the 9.4.1213 milestone Nov 12, 2016
@vlsi vlsi self-assigned this Nov 12, 2016
@vlsi
vlsi approved these changes Nov 12, 2016
@vlsi vlsi closed this in 3d37db7 Nov 12, 2016
@AlexElin AlexElin deleted the AlexElin:ref_host_chooser branch Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.