New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated Utils' methods #678

Merged
merged 3 commits into from Nov 12, 2016

Conversation

Projects
None yet
3 participants
@AlexElin
Contributor

AlexElin commented Nov 4, 2016

remove some deprecated methods from Utils class
add @override on some methods in SimpleParameterList and PgConnection classes

AlexElin added some commits Nov 4, 2016

refactor: remove deprecated Utils' methods
remove some deprecated methods from Utils class
add @override on some methods in SimpleParameterList and PgConnection classes
refactor: remove deprecated Utils' methods
fix failure build with JDK 6
@codecov-io

This comment has been minimized.

codecov-io commented Nov 4, 2016

Current coverage is 62.48% (diff: 100%)

Merging #678 into master will increase coverage by 0.45%

@@             master       #678   diff @@
==========================================
  Files           150        150          
  Lines         15186      15438   +252   
  Methods           0          0          
  Messages          0          0          
  Branches       3055       3086    +31   
==========================================
+ Hits           9419       9646   +227   
- Misses         4521       4533    +12   
- Partials       1246       1259    +13   

Powered by Codecov. Last update 64b6750...f9fdc56

@vlsi

Not sure if toCharArray changes are justified

@@ -197,8 +151,7 @@ private static void doAppendEscapedIdentifier(Appendable sbuf, String value) thr
try {
sbuf.append('"');
for (int i = 0; i < value.length(); ++i) {
char ch = value.charAt(i);
for (char ch : value.toCharArray()) {

This comment has been minimized.

@vlsi

vlsi Nov 10, 2016

Member

I wonder if this change would result array allocation and extra cpu/memory consumption issues

This comment has been minimized.

@AlexElin

AlexElin Nov 10, 2016

Contributor

reverted this change

@@ -110,8 +87,7 @@ private static void doAppendEscapedLiteral(Appendable sbuf, String value,
try {
if (standardConformingStrings) {
// With standard_conforming_strings on, escape only single-quotes.
for (int i = 0; i < value.length(); ++i) {
char ch = value.charAt(i);
for (char ch : value.toCharArray()) {

This comment has been minimized.

@vlsi

vlsi Nov 10, 2016

Member

I wonder if this change would result array allocation and extra cpu/memory consumption issues

This comment has been minimized.

@AlexElin

AlexElin Nov 10, 2016

Contributor

reverted this change

@@ -127,8 +103,7 @@ private static void doAppendEscapedLiteral(Appendable sbuf, String value,
// avoid a security hazard if the reported value of
// standard_conforming_strings is incorrect, or an error if
// backslash_quote is off.
for (int i = 0; i < value.length(); ++i) {
char ch = value.charAt(i);
for (char ch : value.toCharArray()) {

This comment has been minimized.

@vlsi

vlsi Nov 10, 2016

Member

I wonder if this change would result array allocation and extra cpu/memory consumption issues

This comment has been minimized.

@AlexElin

AlexElin Nov 10, 2016

Contributor

reverted this change

@vlsi

vlsi approved these changes Nov 12, 2016

@vlsi vlsi added this to the 9.4.1213 milestone Nov 12, 2016

@vlsi vlsi merged commit 0275d40 into pgjdbc:master Nov 12, 2016

2 checks passed

codecov/project 62.48% (+0.45%) compared to 64b6750
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi

This comment has been minimized.

Member

vlsi commented Nov 12, 2016

Thanks!

@AlexElin AlexElin deleted the AlexElin:refactor_remove_deprecated branch Nov 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment