Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use varargs #681

Closed
wants to merge 1 commit into from
Closed

refactor: use varargs #681

wants to merge 1 commit into from

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Nov 6, 2016

use varargs instead of new Object[]{...}
delete "final" from "private static" methods (fix warnings from #586)

use varargs instead of new Object[]{..}
delete "final" from "private static" methods (fix warnings from #586)
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 6, 2016

Current coverage is 61.99% (diff: 71.42%)

Merging #681 into master will decrease coverage by 0.02%

@@             master       #681   diff @@
==========================================
  Files           150        150          
  Lines         15186      15186          
  Methods           0          0          
  Messages          0          0          
  Branches       3055       3055          
==========================================
- Hits           9419       9415     -4   
- Misses         4521       4523     +2   
- Partials       1246       1248     +2   

Powered by Codecov. Last update 64b6750...98a4d8b

Copy link
Member

@vlsi vlsi left a comment

Not sure if there might be "the only right order of methods/fields/etc".

In general, I think it is good to avoid intermix of field and method declaration. On the other hand, I do not have strong feeling we should always reorder methods.

@@ -164,4 +119,50 @@ public synchronized String decode(byte[] data, int offset, int length) throws IO

return new String(cdata, 0, out);
}

// helper for decode
private static void checkByte(int ch, int pos, int len) throws IOException {

This comment has been minimized.

@vlsi

vlsi Nov 10, 2016
Member

Is there a reason to reorder methods?
That kind of changes clutter git history making it harder to trace root cause.

@vlsi vlsi closed this in 50b7fe0 Nov 12, 2016
@vlsi vlsi added this to the 9.4.1213 milestone Nov 12, 2016
@AlexElin AlexElin deleted the AlexElin:varargs branch Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.