Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to junit4 #685

Merged
merged 11 commits into from Jan 20, 2017
Merged

Migrate to junit4 #685

merged 11 commits into from Jan 20, 2017

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Nov 13, 2016

migrate to Junit4 tests of org.postgresql.test.jdbc2 test package, org.postgresql.test.jdbc4, org.postgresql.test.jdbc42 test packages

#205

AlexElin added 3 commits Nov 10, 2016
migrate to Junit4 in some tests of org.postgresql.test.jdbc2 test package

#205
migrate to Junit4 test of org.postgresql.test.jdbc42 test package

#205
checkstyle

#205
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 13, 2016

Current coverage is 64.12% (diff: 100%)

Merging #685 into master will increase coverage by 0.01%

@@             master       #685   diff @@
==========================================
  Files           164        164          
  Lines         15124      15124          
  Methods           0          0          
  Messages          0          0          
  Branches       2979       2979          
==========================================
+ Hits           9695       9698     +3   
+ Misses         4194       4193     -1   
+ Partials       1235       1233     -2   

Powered by Codecov. Last update cb3995b...7f37586

AlexElin added 6 commits Nov 13, 2016
fix javadoc error

#205
# Conflicts:
#	pgjdbc/src/test/java/org/postgresql/test/jdbc2/BlobTest.java
#	pgjdbc/src/test/java/org/postgresql/test/jdbc2/GeometricTest.java
#	pgjdbc/src/test/java/org/postgresql/test/jdbc2/Jdbc2TestSuite.java
#	pgjdbc/src/test/java/org/postgresql/test/jdbc2/OID74Test.java
#	pgjdbc/src/test/java/org/postgresql/test/jdbc2/TimezoneTest.java
fix checkstyle

#205
# Conflicts:
#	pgjdbc/src/test/java/org/postgresql/test/jdbc2/StatementTest.java
migrate to Junit4 test of org.postgresql.test.jdbc4 test package

#205
migrate to Junit4 test of org.postgresql.test.jdbc3 test package

#205
@AlexElin
Copy link
Contributor Author

@AlexElin AlexElin commented Nov 28, 2016

add org.postgresql.test.jdbc3 test package

AlexElin added 2 commits Nov 29, 2016
migrate to Junit4 tests org.postgresql.test.xa and org.postgresql.test.jdbc2 test packages

#205
@davecramer
Copy link
Member

@davecramer davecramer commented Dec 13, 2016

LGTM, I will merge this unless someone has objections

@jorsol
Copy link
Member

@jorsol jorsol commented Dec 22, 2016

LGTM

@jorsol
Copy link
Member

@jorsol jorsol commented Jan 12, 2017

@davecramer , I guess nobody has objections.

@vlsi
Copy link
Member

@vlsi vlsi commented Jan 20, 2017

Master:

Tests run: 3638, Failures: 0, Errors: 0, Skipped: 5

Current PR

Tests run: 3638, Failures: 0, Errors: 0, Skipped: 4

@AlexElin , thanks for cleaning the stuff.

@vlsi vlsi merged commit faab499 into pgjdbc:master Jan 20, 2017
2 checks passed
2 checks passed
codecov/project 64.12% (+0.01%) compared to cb3995b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi vlsi added this to the 42.0.0 milestone Jan 20, 2017
@AlexElin AlexElin deleted the AlexElin:migrate_to_junit4 branch Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants