Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up PgDatabaseMetaData #692

Merged
merged 1 commit into from Nov 25, 2016

Conversation

@marschall
Copy link
Contributor

@marschall marschall commented Nov 24, 2016

PgDatabaseMetaData contains the methods rowChangesAreDetected,
rowChangesAreVisible and providesQueryObjectGenerator. They are not
documented, have no tests, always returns false and are not specified
in DatabaseMetaData.

This commit removes them.

PgDatabaseMetaData contains the methods rowChangesAreDetected,
rowChangesAreVisible and providesQueryObjectGenerator. They are not
documented, have no tests, always returns false and are not specified
in DatabaseMetaData.

This commit removes them.
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 24, 2016

Current coverage is 63.31% (diff: 100%)

Merging #692 into master will decrease coverage by <.01%

@@             master       #692   diff @@
==========================================
  Files           151        151          
  Lines         14790      14787     -3   
  Methods           0          0          
  Messages          0          0          
  Branches       2934       2934          
==========================================
- Hits           9366       9363     -3   
+ Misses         4216       4214     -2   
- Partials       1208       1210     +2   

Powered by Codecov. Last update f75572b...dd44239

@davecramer
Copy link
Member

@davecramer davecramer commented Nov 24, 2016

interesting, wonder how they got there?

@@ -2524,10 +2514,6 @@ public ResultSet getClientInfoProperties() throws SQLException {
return ((BaseStatement) createMetaDataStatement()).createDriverResultSet(f, v);
}

public boolean providesQueryObjectGenerator() throws SQLException {

This comment has been minimized.

@vlsi

vlsi Nov 25, 2016
Member

https://issues.apache.org/jira/browse/DERBY-3423
DatabaseMetaData.providesQueryObjectGenerator() was removed from the spec right before JDBC 4.0 was final, but it's still implemented in Derby. The implementations of this method should be removed.

I think pgjdbc has somewhat similar history. That is the method was implemented in the anticipation of JDBC 4.0, and the method was dropped before the spec went final.

@vlsi vlsi added this to the 9.4.1213 milestone Nov 25, 2016
@vlsi vlsi merged commit d32b077 into pgjdbc:master Nov 25, 2016
2 checks passed
2 checks passed
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +36.67% compared to f75572b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.