New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: ignore tests that don't apply to Pg8.2 and Pg8.3 #703

Merged
merged 1 commit into from Dec 22, 2016

Conversation

Projects
None yet
4 participants
@jorsol
Contributor

jorsol commented Dec 6, 2016

Some tests requiere features not available in PostgreSQL 8.2 and PostgreSQL 8.3, this PR ignore the test that won't work on it.

@davecramer

This comment has been minimized.

Member

davecramer commented Dec 7, 2016

Looks good to me

@jorsol jorsol force-pushed the jorsol:test-ignore-pg82 branch from 9a2a4a7 to 02ac46c Dec 12, 2016

@jorsol jorsol changed the title from test: ignore tests that don't apply to Pg8.2 to test: ignore tests that don't apply to Pg8.2 and Pg8.3 Dec 12, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Dec 12, 2016

Current coverage is 64.08% (diff: 100%)

Merging #703 into master will decrease coverage by <.01%

@@             master       #703   diff @@
==========================================
  Files           164        164          
  Lines         15124      15124          
  Methods           0          0          
  Messages          0          0          
  Branches       2979       2979          
==========================================
- Hits           9693       9692     -1   
- Misses         4195       4197     +2   
+ Partials       1236       1235     -1   

Powered by Codecov. Last update 436365b...02ac46c

@jorsol

This comment has been minimized.

Contributor

jorsol commented Dec 12, 2016

The only failing test is:

org.postgresql.test.jdbc2.AutoRollbackTestSuite
run[22: autorollback(autoSave=NEVER, autoCommit=NO, failMode=ALTER, continueMode=SELECT, flushOnDeallocate=true)]

wich I'm not sure the correct way to handle it, I could add an minServer 8.3 to this if, but since is a complex test, I don't know if it's correct.

      if (autoSave == AutoSave.NEVER
          && con.unwrap(PGConnection.class).getPreferQueryMode() != PreferQueryMode.SIMPLE) {
        Assert.fail("autosave=NEVER, thus the transaction should be killed");
      }
@jorsol

This comment has been minimized.

Contributor

jorsol commented Dec 21, 2016

Any news on this? this can be safely merged and check the "run[22:" later as this have a StringTypeParameterTest.java fix and remove the PG8.3 from the allowed failed tests.

@davecramer davecramer merged commit 3bc0951 into pgjdbc:master Dec 22, 2016

2 checks passed

codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +35.90% compared to 436365b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vlsi vlsi added this to the 42.0.0 milestone Dec 30, 2016

@jorsol jorsol deleted the jorsol:test-ignore-pg82 branch Jan 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment