Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve violations from checkstyle 7.4 #725

Merged
merged 1 commit into from Jan 9, 2017
Merged

Conversation

@romani
Copy link
Contributor

@romani romani commented Dec 30, 2016

Issue #724

  1. extra space was removed
  2. fix RightCurly configuration problem, the same update was done in checkstyle project, (checkstyle/checkstyle#3678). DO_WHILE was moved from one RightCurly configuration to another.
  3. validation of CallableQueryKey.java is skipped as maintainers do not want fix violation of missed equals() for now
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 30, 2016

Current coverage is 64.23% (diff: 100%)

Merging #725 into master will decrease coverage by <.01%

@@             master       #725   diff @@
==========================================
  Files           163        163          
  Lines         15142      15142          
  Methods           0          0          
  Messages          0          0          
  Branches       2987       2987          
==========================================
- Hits           9727       9726     -1   
- Misses         4182       4183     +1   
  Partials       1233       1233          

Powered by Codecov. Last update 3a00ef9...43b0593

@davecramer
Copy link
Member

@davecramer davecramer commented Dec 30, 2016

This is failing on

do {
...
} while test

I do not want to see this particular code construct being changed

@romani
Copy link
Contributor Author

@romani romani commented Dec 31, 2016

This supposed to be resolved by my change at pgjdbc/src/main/checkstyle/checks.xml , i forgot to put changes to checkstyle version to 7.4 . I will do this ones a get to keyboard.

@jorsol
Copy link
Contributor

@jorsol jorsol commented Jan 1, 2017

@romani , you can remove the exclude for CallableQueryKey.java now, the equals() is added in this commit: 401c51a

…nfiguration problem, validation of CallableQueryKey.java is skipped as mainteners do not want fix violation of missed equals() for now
@romani
Copy link
Contributor Author

@romani romani commented Jan 1, 2017

@jorsol , exclude is removed.

@davecramer , I added more fixes for occasional extra line in imports. From 7.4 this is also considered as violation.

as CI is enforced by your CI , can our team expect that you will not have in master HEAD code that violates checkstyle ?

It will help me to make a decision to put pgjdbc in checkstyle's CI by certain version(hash) or by HEAD of master. I would prefer to have your latest code in our CI.

@jorsol
Copy link
Contributor

@jorsol jorsol commented Jan 2, 2017

yes the checkstyle is enforced by the CI, master HEAD should not have code that violates checkstyle.

@romani
Copy link
Contributor Author

@romani romani commented Jan 2, 2017

Thanks , ones you merge this PR. I will proceed on my side.

@romani
Copy link
Contributor Author

@romani romani commented Jan 9, 2017

@jorsol, @davecramer , if smth is not clear in changes please let me know I will provide wide description.

@vlsi vlsi merged commit e1a2578 into pgjdbc:master Jan 9, 2017
2 checks passed
2 checks passed
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +35.76% compared to 3a00ef9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi
Copy link
Member

@vlsi vlsi commented Jan 9, 2017

@romani , thanks for the fix

@vlsi vlsi added this to the 42.0.0 milestone Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.