Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
fix: use SQLWarning(String reason) constructor for correct DriverMana… #751
@@ Coverage Diff @@ ## master #751 +/- ## ============================================ + Coverage 65.24% 65.27% +0.02% - Complexity 3495 3496 +1 ============================================ Files 164 164 Lines 15125 15123 -2 Branches 2450 2450 ============================================ + Hits 9869 9871 +2 + Misses 4078 4075 -3 + Partials 1178 1177 -1
I thought of more like a end-to-end test. That is execute SQL with error and ensure the message is there.
As far as I can see, it is even better to use
I didn't know what a good value for the vendorCode would be, so I just switched it to the
I agree that an ETE test would be nicer than hardcoding the test, though I'm actually not very familiar with this codebase so I'd need to poke around a bit if you would like me to add that kind of test. Alternatively, I'm happy to add you as a collaborator on my fork @vlsi if you would prefer to just make the addition yourself (or you can just recreate this branch on this repo and then add the ETE test). Let me know which of these three options works best for you.
…ger logging Previously, the default constructor was used which only logs "SQLWarning: ", but no information about the warning.
pgjdbc#751) * fix: use SQLWarning(String reason) constructor for correct DriverManager logging Previously, the default constructor was used which only logs "SQLWarning: ", but no information about the warning.