fix: add isLoggable around parameterized logger #752
Merged
Conversation
Enclose Logger with isLoggable in multi-parameter cases.
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
============================================
- Coverage 65.62% 65.36% -0.26%
+ Complexity 3502 3498 -4
============================================
Files 164 164
Lines 15091 15110 +19
Branches 2427 2442 +15
============================================
- Hits 9903 9877 -26
- Misses 4035 4062 +27
- Partials 1153 1171 +18 Continue to review full report at Codecov.
|
thx! |
PS. I wish there was a source pre-processor that could automatically wrap logging statements at compile time. PPS. Java annotation processors have no public API to alter source code (processors can just add new classes), so annotation processing can't help here. |
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Sep 19, 2017
Enclose Logger with isLoggable in multi-parameter cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Enclose Logger with isLoggable in multi-parameter cases.