New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add isLoggable around parameterized logger #752

Merged
merged 1 commit into from Feb 18, 2017

Conversation

Projects
None yet
4 participants
@jorsol
Contributor

jorsol commented Feb 17, 2017

Enclose Logger with isLoggable in multi-parameter cases.

fix: add isLoggable around parameterized logger
Enclose Logger with isLoggable in multi-parameter cases.
@codecov-io

This comment has been minimized.

codecov-io commented Feb 17, 2017

Codecov Report

Merging #752 into master will decrease coverage by -0.26%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #752      +/-   ##
============================================
- Coverage     65.62%   65.36%   -0.26%     
+ Complexity     3502     3498       -4     
============================================
  Files           164      164              
  Lines         15091    15110      +19     
  Branches       2427     2442      +15     
============================================
- Hits           9903     9877      -26     
- Misses         4035     4062      +27     
- Partials       1153     1171      +18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b355327...493e4d6. Read the comment docs.

@davecramer

This comment has been minimized.

Member

davecramer commented Feb 18, 2017

thx!

@vlsi

This comment has been minimized.

Member

vlsi commented Feb 18, 2017

PS. I wish there was a source pre-processor that could automatically wrap logging statements at compile time.

PPS. Java annotation processors have no public API to alter source code (processors can just add new classes), so annotation processing can't help here.
Lombok uses some non-public API, so it might have issues with Java 9.

@vlsi vlsi merged commit 8b50cfe into pgjdbc:master Feb 18, 2017

1 of 2 checks passed

codecov/project 65.36% (-0.26%) compared to b355327
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vlsi vlsi added this to the 42.0.0 milestone Feb 18, 2017

davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017

fix: add isLoggable around parameterized logger (pgjdbc#752)
Enclose Logger with isLoggable in multi-parameter cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment