New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replication docs use PREFER_QUERY_MODE #761

Merged
merged 1 commit into from Feb 23, 2017

Conversation

Projects
None yet
4 participants
@jpfuentes2
Contributor

jpfuentes2 commented Feb 23, 2017

The follow prop must be set:

PGProperty.PREFER_QUERY_MODE.set(props, "simple");

on a replication connection to create replication slots. The
docs demonstrate this in the full example near the bottom of
the page but not at the top where it shows creating a slot
thru pgjdbc.

fixes #759

Jacques Fuentes
Make replication docs use PREFER_QUERY_MODE
The follow prop must be set:

```
PGProperty.PREFER_QUERY_MODE.set(props, "simple");
```

on a replication connection to create replication slots. The
docs demonstrate this in the full example near the bottom of
the page but not at the top where it shows creating a slot
thru pgjdbc.

fixes #759
@codecov-io

This comment has been minimized.

codecov-io commented Feb 23, 2017

Codecov Report

Merging #761 into master will decrease coverage by -0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #761      +/-   ##
============================================
- Coverage     65.27%   65.25%   -0.02%     
+ Complexity     3497     3496       -1     
============================================
  Files           164      164              
  Lines         15120    15120              
  Branches       2450     2450              
============================================
- Hits           9869     9867       -2     
- Misses         4075     4076       +1     
- Partials       1176     1177       +1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1eb34...2e407e1. Read the comment docs.

@davecramer davecramer merged commit bd0497d into pgjdbc:master Feb 23, 2017

1 of 2 checks passed

codecov/project 65.25% (-0.02%) compared to 3e1eb34
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jpfuentes2 jpfuentes2 deleted the SimpleFinance:fix_replication_docs_for_slot_creation branch Feb 23, 2017

@vlsi vlsi added this to the 42.0.1 milestone Mar 3, 2017

davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017

Make replication docs use PREFER_QUERY_MODE (pgjdbc#761)
The follow prop must be set:

```
PGProperty.PREFER_QUERY_MODE.set(props, "simple");
```

on a replication connection to create replication slots. The
docs demonstrate this in the full example near the bottom of
the page but not at the top where it shows creating a slot
thru pgjdbc.

fixes pgjdbc#759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment