refactor: simplify Encoding class #765
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
============================================
+ Coverage 65.24% 65.25% +<.01%
- Complexity 3495 3496 +1
============================================
Files 164 164
Lines 15125 15126 +1
Branches 2450 2451 +1
============================================
+ Hits 9869 9871 +2
- Misses 4078 4079 +1
+ Partials 1178 1176 -2Continue to review full report at Codecov.
|
|
|
||
| /* | ||
| * Preferred JVM encodings for backend encodings. | ||
| */ | ||
| private static final HashMap<String, String[]> encodings = new HashMap<String, String[]>(); | ||
| private static final HashMap<String, String[]> ENCODINGS = new HashMap<String, String[]>(); |
davecramer
Mar 15, 2017
Member
ENCODING is not really immutable so it really should be in lower case here
ENCODING is not really immutable so it really should be in lower case here
vlsi
Mar 15, 2017
Member
I believe it is never modified during the run-time, so upper case is perfectly fine
I believe it is never modified during the run-time, so upper case is perfectly fine
davecramer
Mar 15, 2017
Member
paraphrasing google style guide "merely intending not to change it is not enough"
paraphrasing google style guide "merely intending not to change it is not enough"
jorsol
Mar 15, 2017
Author
Member
done
done
|
+1 |
davecramer
added a commit
to davecramer/pgjdbc
that referenced
this pull request
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Little refactor to simplify the Encoding class.