New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify Encoding class #765

Merged
merged 1 commit into from Mar 23, 2017

Conversation

Projects
None yet
4 participants
@jorsol
Contributor

jorsol commented Feb 27, 2017

Little refactor to simplify the Encoding class.

@jorsol jorsol force-pushed the jorsol:refactor-encoding branch from 16d0838 to 50ac0a1 Feb 27, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Feb 27, 2017

Codecov Report

Merging #765 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #765      +/-   ##
============================================
+ Coverage     65.24%   65.25%   +<.01%     
- Complexity     3495     3496       +1     
============================================
  Files           164      164              
  Lines         15125    15126       +1     
  Branches       2450     2451       +1     
============================================
+ Hits           9869     9871       +2     
- Misses         4078     4079       +1     
+ Partials       1178     1176       -2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2a02e...3d8e284. Read the comment docs.

@jorsol jorsol force-pushed the jorsol:refactor-encoding branch from 50ac0a1 to 68082cf Feb 27, 2017

/*
* Preferred JVM encodings for backend encodings.
*/
private static final HashMap<String, String[]> encodings = new HashMap<String, String[]>();
private static final HashMap<String, String[]> ENCODINGS = new HashMap<String, String[]>();

This comment has been minimized.

@davecramer

davecramer Mar 15, 2017

Member

ENCODING is not really immutable so it really should be in lower case here

This comment has been minimized.

@vlsi

vlsi Mar 15, 2017

Member

I believe it is never modified during the run-time, so upper case is perfectly fine

This comment has been minimized.

@davecramer

davecramer Mar 15, 2017

Member

paraphrasing google style guide "merely intending not to change it is not enough"

This comment has been minimized.

@jorsol

jorsol Mar 15, 2017

Contributor

done

@jorsol jorsol force-pushed the jorsol:refactor-encoding branch from 68082cf to 3d8e284 Mar 15, 2017

@davecramer

This comment has been minimized.

Member

davecramer commented Mar 15, 2017

+1

@davecramer davecramer merged commit ef8c6f9 into pgjdbc:master Mar 23, 2017

2 checks passed

codecov/project 65.25% (+<.01%) compared to 3f2a02e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment