New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honour setLogStream. If the logStream is set #780

Merged
merged 5 commits into from Mar 23, 2017

Conversation

Projects
None yet
3 participants
@davecramer
Member

davecramer commented Mar 13, 2017

then use it to output logs
Also set the parent logger level to the log level
requested.

Honour setLogStream. If the logStream is set
then use it to output logs
Also set the parent logger level to the log level
requested.
@codecov-io

This comment has been minimized.

codecov-io commented Mar 13, 2017

Codecov Report

Merging #780 into master will increase coverage by 0.02%.
The diff coverage is 45%.

@@             Coverage Diff              @@
##             master     #780      +/-   ##
============================================
+ Coverage     65.25%   65.27%   +0.02%     
- Complexity     3496     3506      +10     
============================================
  Files           164      165       +1     
  Lines         15125    15183      +58     
  Branches       2450     2455       +5     
============================================
+ Hits           9870     9911      +41     
- Misses         4078     4088      +10     
- Partials       1177     1184       +7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c80adc...2725aee. Read the comment docs.

@vlsi

This comment has been minimized.

Member

vlsi commented Mar 13, 2017

Could you please add a test for the feature?

davecramer added some commits Mar 14, 2017

Added a WriterHandler, borrowed and attributed to apache
suppress our copyright check for that file
added the first test case for WriterHandler

@davecramer davecramer merged commit b97ad63 into pgjdbc:master Mar 23, 2017

2 checks passed

codecov/project 65.27% (+0.02%) compared to 9c80adc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017

Honour setLogStream. If the logStream is set (pgjdbc#780)
* Honour setLogStream. If the logStream is set
then use it to output logs
Also set the parent logger level to the log level
requested.

* Added a WriterHandler, borrowed and attributed to apache
suppress our copyright check for that file
added the first test case for WriterHandler

* added seperate test for setLogStream

* suppress the output from the logging tests

* moved utility class to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment