Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing connection documentation, fix spelling #846

Merged
merged 3 commits into from Jun 26, 2017

Conversation

@davecramer
Copy link
Member

@davecramer davecramer commented Jun 18, 2017

No description provided.

@codecov-io
Copy link

@codecov-io codecov-io commented Jun 18, 2017

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #846   +/-   ##
=========================================
  Coverage     65.57%   65.57%           
  Complexity     3549     3549           
=========================================
  Files           166      166           
  Lines         15254    15254           
  Branches       2475     2475           
=========================================
  Hits          10003    10003           
  Misses         4070     4070           
  Partials       1181     1181

Specifies which mode is used to execute queries to database: simple means ('Q' execute, no parse, no bind, text mode only),
extended means always use bind/execute messages, extendedForPrepared means extended for prepared statements only,
extendedCacheEverything means use extended protocol and try cache every statement (including Statement.execute(String sql)) in a query cache.", false,

This comment has been minimized.

@vlsi

vlsi Jun 19, 2017
Member

What does false mean here?

@@ -343,7 +356,9 @@ Connection conn = DriverManager.getConnection(url);

* **disableColumnSanitiser** = boolean

Enable optimization that disables column name sanitiser.
Enable optimization that disables column name sanitiser.

This comment has been minimized.

@vlsi

vlsi Jun 19, 2017
Member

I'm afraid this description does not make the meaning clean.

Should it be something around the following?

caseSensitiveColumnAccessors (former name disableColumnSanitiser) with values true/false. Default false. When enabled, ResultSet#get..(String) would access column names in a case-sensitive way.

@@ -375,14 +375,14 @@
"extended", "extendedForPrepared", "extendedCacheEveryting", "simple"),

This comment has been minimized.

@jorsol

jorsol Jun 21, 2017
Contributor

Should be fixed the property too? "extendedCacheEveryting" => "extendedCacheEverything"

@davecramer
Copy link
Member Author

@davecramer davecramer commented Jun 21, 2017

@davecramer davecramer merged commit cd400f6 into pgjdbc:master Jun 26, 2017
2 checks passed
2 checks passed
codecov/project 65.57% remains the same compared to 464a2d4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017
* add missing connection documentation, fix spelling

* clarify some descriptions

* fix spelling for extendedCacheEverything
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.