Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #859

Merged
merged 1 commit into from Jun 30, 2018
Merged

Update CONTRIBUTING.md #859

merged 1 commit into from Jun 30, 2018

Conversation

@michele-mancioppi
Copy link
Contributor

@michele-mancioppi michele-mancioppi commented Jun 30, 2017

Clarify that the build needs a database and a user called both test to run.

Clarify that the build needs a database and a user called both `test` to run.
@codecov-io
Copy link

@codecov-io codecov-io commented Jun 30, 2017

Codecov Report

Merging #859 into master will decrease coverage by 1.75%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #859      +/-   ##
============================================
- Coverage     67.38%   65.62%   -1.76%     
+ Complexity     3687     3551     -136     
============================================
  Files           170      166       -4     
  Lines         15638    15248     -390     
  Branches       2531     2473      -58     
============================================
- Hits          10538    10007     -531     
- Misses         3917     4062     +145     
+ Partials       1183     1179       -4
@vlsi
Copy link
Member

@vlsi vlsi commented Jul 5, 2017

By the way, there's a hidden gem https://github.com/pgjdbc/pgjdbc/blob/master/pgjdbc/src/test/java/org/postgresql/test/README.md
We might want to merge it with CONTRIBUTING.md

@michele-mancioppi
Copy link
Contributor Author

@michele-mancioppi michele-mancioppi commented Jul 5, 2017

Yeah, that would have saved me ten frustrating minutes :D

@vlsi vlsi force-pushed the pgjdbc:master branch from 4a6d1d1 to 5819f31 Jan 17, 2018
@vlsi vlsi added the documentation label Jun 30, 2018
@vlsi vlsi added this to the 42.2.3 milestone Jun 30, 2018
@vlsi vlsi merged commit 83f2e38 into pgjdbc:master Jun 30, 2018
1 of 2 checks passed
1 of 2 checks passed
codecov/project 65.62% (-1.76%) compared to 44bb7f8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Clarify that the build needs a database and a user called both `test` to run.
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Clarify that the build needs a database and a user called both `test` to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.