New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

honour PGPORT, PGHOST, PGDBNAME in connection properties #862

Merged
merged 4 commits into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@davecramer
Member

davecramer commented Jul 7, 2017

Previously setting these in properties passed to DriverManager.getConnection(url, props) were ignored

if (defaults != null && !defaults.containsKey("PGPORT")) {
urlProps.setProperty("PGPORT", "/*$mvn.project.property.template.default.pg.port$*/");
} else {
urlProps.setProperty("PGPORT", "/*$mvn.project.property.template.default.pg.port$*/");

This comment has been minimized.

@vlsi

vlsi Jul 17, 2017

Member

The above looks like an unconditional update of urlProps.setProperty("PGPORT". Is if required at all in such case? Was something other than urlProps expected here?

This comment has been minimized.

@davecramer

davecramer Jul 17, 2017

Member

yup, looks like what it is :(

@codecov-io

This comment has been minimized.

codecov-io commented Jul 17, 2017

Codecov Report

Merging #862 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master     #862      +/-   ##
============================================
+ Coverage     65.63%   65.63%   +<.01%     
- Complexity     3542     3544       +2     
============================================
  Files           166      166              
  Lines         15252    15255       +3     
  Branches       2474     2477       +3     
============================================
+ Hits          10010    10012       +2     
+ Misses         4062     4061       -1     
- Partials       1180     1182       +2

@davecramer davecramer merged commit 2951a95 into pgjdbc:master Jul 25, 2017

2 checks passed

codecov/project 65.63% (+<.01%) compared to 201daf1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davecramer davecramer deleted the davecramer:fixproperties branch Jul 25, 2017

@vlsi vlsi added this to the 42.1.4 milestone Jul 25, 2017

davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017

honour PGPORT, PGHOST, PGDBNAME in connection properties (pgjdbc#862)
* honour PGPORT, PGHOST, PGDBNAME in connection properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment