Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to Junit4 #883

Merged
merged 7 commits into from Jul 26, 2017
Merged

refactor: migrate to Junit4 #883

merged 7 commits into from Jul 26, 2017

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Jul 24, 2017

migrate XATestSuite, Jdbc2TestSuite, Jdbc4TestSuite, ExtensionsTestSuite test suites

#205

AlexElin added 4 commits Jul 24, 2017
migrate XATestSuite, Jdbc2TestSuite, Jdbc4TestSuite, ExtensionsTestSuite test suites

#205
fix NPE and SQLException while dropping non-existing table

#205
fix SQLException while dropping non-existing domain

#205
fix SQLException while dropping non-existing table

#205
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 24, 2017

Codecov Report

Merging #883 into master will increase coverage by 0.1%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #883     +/-   ##
===========================================
+ Coverage     65.65%   65.76%   +0.1%     
- Complexity     3543     3547      +4     
===========================================
  Files           166      166             
  Lines         15253    15253             
  Branches       2474     2474             
===========================================
+ Hits          10015    10031     +16     
+ Misses         4059     4048     -11     
+ Partials       1179     1174      -5
Statement stmt = _conn.createStatement();
super.setUp();
assumeTrue(TestUtil.haveMinimumServerVersion(con, ServerVersion.v8_3));
assumeTrue("Server have been complied --with-libxml",isXmlEnabled(con));

This comment has been minimized.

This comment has been minimized.

@AlexElin

AlexElin Jul 25, 2017
Author Contributor

fixed

This comment has been minimized.

@davecramer

davecramer Jul 25, 2017
Member

nit picking here, but could you change
assumeTrue("Server have been complied --with-libxml",isXmlEnabled(con));
to
assumeTrue("Server has been complied --with-libxml",isXmlEnabled(con));

have -> has

Thanks

@@ -31,6 +33,7 @@
@Before
public void setUp() throws Exception {
con = TestUtil.openDB();
assumeTrue(TestUtil.haveMinimumServerVersion(con, ServerVersion.v9_3));

This comment has been minimized.

@panchenko

panchenko Jul 25, 2017

As an idea: might be introduce a method like assumeMinimumServerVersion(con, ServerVersion.v9_3) ?

This comment has been minimized.

@AlexElin

AlexElin Jul 25, 2017
Author Contributor

good idea. Implemented it

This comment has been minimized.

@vlsi

vlsi Jul 25, 2017
Member

What about BaseTest4#assumeMinimumServerVersion(ServerVersion)?
Or even existing HaveMinimalServerVersion rule? (see

)

This comment has been minimized.

@AlexElin

AlexElin Jul 25, 2017
Author Contributor

made assumeMinimumServerVersion in the BaseTest4.

AlexElin added 2 commits Jul 25, 2017
fix misspelling + add TestUtil.assumeMinimumServerVersion methods

#205
fix checkstyle

#205
Statement stmt = _conn.createStatement();
super.setUp();
TestUtil.assumeMinimumServerVersion(con, ServerVersion.v8_3);
assumeTrue("Server has been complied --with-libxml", isXmlEnabled(con));

This comment has been minimized.

@vlsi

vlsi Jul 25, 2017
Member

s/complied/compiled/?

This comment has been minimized.

@davecramer

davecramer Jul 25, 2017
Member

yes of course, good catch

This comment has been minimized.

@AlexElin

AlexElin Jul 25, 2017
Author Contributor

fixed)

fix misspelling + move assumeMinimumServerVersion to BaseTest4

#205
@vlsi
Copy link
Member

@vlsi vlsi commented Jul 26, 2017

@AlexElin , do you intend to make more changes here?

I think this is ready for merge.

@AlexElin
Copy link
Contributor Author

@AlexElin AlexElin commented Jul 26, 2017

@vlsi I don't intend to make changes here

@vlsi vlsi merged commit 5c12da1 into pgjdbc:master Jul 26, 2017
2 checks passed
2 checks passed
codecov/project 65.76% (+0.1%) compared to f0deabf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi vlsi added this to the 42.1.4 milestone Jul 26, 2017
@AlexElin AlexElin deleted the AlexElin:migrate_to_junit4 branch Jul 27, 2017
davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017
Migrate XATestSuite, Jdbc2TestSuite, Jdbc4TestSuite, ExtensionsTestSuite test suites

see pgjdbc#205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants