Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate MultiHostsConnectionTest to JUnit4 #886

Merged
merged 16 commits into from Jun 1, 2018

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Jul 27, 2017

MultiHostsConnectionTest

#205

AlexElin added 2 commits Jul 27, 2017
MultiHostsConnectionTest

#205
fix fail on JDK 6

#205
@codecov-io
Copy link

@codecov-io codecov-io commented Jul 27, 2017

Codecov Report

Merging #886 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #886      +/-   ##
============================================
+ Coverage     67.18%   67.18%   +<.01%     
- Complexity     3657     3658       +1     
============================================
  Files           170      170              
  Lines         15613    15613              
  Branches       2519     2519              
============================================
+ Hits          10489    10490       +1     
+ Misses         3937     3936       -1     
  Partials       1187     1187
@@ -52,17 +53,24 @@ public static int getSlavePort() {
public static TestSuite suite() throws Exception {
TestSuite suite = new TestSuite();

if (isReplicationInstanceAvailable()) {

This comment has been minimized.

@panchenko

panchenko Jul 28, 2017

might be assume in @BeforeClass?

This comment has been minimized.

@AlexElin

AlexElin Jul 28, 2017
Author Contributor

Yes. I'm going to move it into @BeforeClass in the test class

AlexElin added 4 commits Jul 28, 2017
migrate MultiHostTestSuite

#205
fix checkstyle

#205
SslTest: remove tests for v2 protocol + some simplifications
SingleCertValidatingFactoryTestSuite: use TestUtil

#205
revert changes in SslTestSuite.java

#205
@vlsi
Copy link
Member

@vlsi vlsi commented Jul 29, 2017

SslTest.java changes bother me in a sense that Travis jobs do not exercise SSL/TLS.
I wonder if it is possible to update a job or two and make sure SSL tests are executed.

@vlsi
Copy link
Member

@vlsi vlsi commented Sep 25, 2017

@AlexElin , is it still WIP? Do you intend to get it committed?

AlexElin added 2 commits Oct 1, 2017
This reverts commit fd957c5
@AlexElin AlexElin changed the title [WIP]refactor: migrate to Junit4 refactor: migrate to Junit4 Oct 1, 2017
@AlexElin
Copy link
Contributor Author

@AlexElin AlexElin commented Oct 1, 2017

@vlsi I removed WIP. I've reverted the changes for SSLtest because Travis jobs do not exercise SSL/TLS. And I have no plans to make changes here

AlexElin added 4 commits Jan 11, 2018
# Conflicts:
#	pgjdbc/src/test/java/org/postgresql/test/hostchooser/MultiHostTestSuite.java
#	pgjdbc/src/test/java/org/postgresql/test/hostchooser/MultiHostsConnectionTest.java
resolve merge conflicts

#205
fix test failure

#205
fix test failure

#205
@vlsi vlsi force-pushed the pgjdbc:master branch from 4a6d1d1 to 5819f31 Jan 17, 2018
AlexElin added 4 commits Jan 23, 2018
# Conflicts:
#	pgjdbc/src/test/java/org/postgresql/test/hostchooser/MultiHostTestSuite.java
#	pgjdbc/src/test/java/org/postgresql/test/hostchooser/MultiHostsConnectionTest.java
fix test failure

#205
salve -> secondary

#205
fix messages

#205
@AlexElin
Copy link
Contributor Author

@AlexElin AlexElin commented May 31, 2018

@vlsi can we get this PR merged?

@vlsi vlsi changed the title refactor: migrate to Junit4 refactor: migrate MultiHostsConnectionTest to JUnit4 Jun 1, 2018
@vlsi vlsi merged commit 17a4d6a into pgjdbc:master Jun 1, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vlsi vlsi added this to the 42.2.3 milestone Jun 1, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this pull request Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants