Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dead code from PGStream, implement Closeable #901

Merged
merged 1 commit into from Aug 3, 2017

Conversation

@AlexElin
Copy link
Contributor

@AlexElin AlexElin commented Aug 3, 2017

make PGStream closable + remove receiveTupleV2 method

make PGStream closable + remove receiveTupleV2 method
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 3, 2017

Codecov Report

Merging #901 into master will increase coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #901      +/-   ##
============================================
+ Coverage     65.75%   65.87%   +0.11%     
  Complexity     3548     3548              
============================================
  Files           166      166              
  Lines         15256    15229      -27     
  Branches       2477     2470       -7     
============================================
  Hits          10032    10032              
+ Misses         4048     4020      -28     
- Partials       1176     1177       +1
@davecramer
Copy link
Member

@davecramer davecramer commented Aug 3, 2017

+1 from me

@vlsi vlsi added this to the 42.1.5 milestone Aug 3, 2017
@vlsi vlsi changed the title refactor: PGStream refactor: PGStream remove dead code, implement Closeable Aug 3, 2017
@vlsi vlsi changed the title refactor: PGStream remove dead code, implement Closeable refactor: remove dead code from PGStream, implement Closeable Aug 3, 2017
@vlsi vlsi merged commit acff949 into pgjdbc:master Aug 3, 2017
2 checks passed
2 checks passed
codecov/project 65.87% (+0.11%) compared to fd86e66
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017
@vlsi vlsi modified the milestones: 42.1.5, 42.2.0 Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants