New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove deprecated maxLineLength from LeftCurlyCheck #904

Merged
merged 1 commit into from Aug 3, 2017

Conversation

Projects
None yet
3 participants
@rnveach
Contributor

rnveach commented Aug 3, 2017

This PR is being created because of a backward breaking change being made in CheckStyle.
PR: checkstyle/checkstyle#4893
Issue: checkstyle/checkstyle#3671

We are breaking multiple APIs in Checkstyle 8 to clean up deprecated methods and such. This removed the deprecated property maxLineLength in LeftCurly as it wasn't doing anything and it's functionality was removed some time ago.

You can either accept this PR and not have an issue when you upgrade CS with this fix in the future,
or make your own change/fix later when you do upgrade CS.
Please let us know which way you intend to go.

Feel free to ask any questions.
Thanks.

@vlsi vlsi added this to the 42.1.5 milestone Aug 3, 2017

@vlsi vlsi merged commit 5f083d1 into pgjdbc:master Aug 3, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@vlsi

This comment has been minimized.

Member

vlsi commented Aug 3, 2017

@rnveach , thanks

@codecov-io

This comment has been minimized.

codecov-io commented Aug 3, 2017

Codecov Report

Merging #904 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #904      +/-   ##
============================================
+ Coverage     65.85%   65.86%   +<.01%     
- Complexity     3546     3547       +1     
============================================
  Files           166      166              
  Lines         15229    15229              
  Branches       2470     2470              
============================================
+ Hits          10029    10030       +1     
  Misses         4022     4022              
+ Partials       1178     1177       -1

@rnveach rnveach deleted the rnveach:cs_issue_3671 branch Aug 3, 2017

@vlsi

This comment has been minimized.

Member

vlsi commented Aug 4, 2017

@rnveach , I see Checkstyle Werker Pgjdbc job uses a patch (see https://github.com/checkstyle/checkstyle/blob/master/wercker.yml#L50-L51 )
Should that be incorporated to pgjdbc sources as well?

@rnveach

This comment has been minimized.

Contributor

rnveach commented Aug 4, 2017

@vlsi Yes, you can make those changes, but it requires you to also upgrade to Checkstyle 8.1 as it was another backward breaking change only available in that release.
See checkstyle/checkstyle#4714

davecramer added a commit to davecramer/pgjdbc that referenced this pull request Sep 19, 2017

@vlsi vlsi modified the milestones: 42.1.5, 42.2.0 Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment