Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Added quotes to URL in '@see' tag over NTDSAPI#DsMakeSpnW #926

Merged
merged 1 commit into from Aug 28, 2017
Merged

doc: Added quotes to URL in '@see' tag over NTDSAPI#DsMakeSpnW #926

merged 1 commit into from Aug 28, 2017

Conversation

@voidfist
Copy link
Contributor

@voidfist voidfist commented Aug 27, 2017

doc: Added quotes to URL in '@see' tag over org.postgresql.sspi.NTDSAPI#DsMakeSpnW for syntactic correctness

The javadoc syntax in oracle docs states that a string should be enclosed in quotes. Even javadoc tool itself gives an error if unquoted strings are used as @see tag's argument. On the other hand references in @see tag don't need any quotes which can also be concluded looking at the syntax.

checkstyle has actually decided to lay down parse errors for such cases. checkstyle uses pgjdbc repo in wercker CI and this particular input case results in CI failure.

See also: checkstyle/pull/4550#issuecomment, checkstyle/issues/4752, checkstyle/pull/5011#issuecomment

voidfist added a commit to voidfist/checkstyle that referenced this issue Aug 27, 2017
…ut quotes in '@see' tag. Updated 'wercker.yml' to apply a patch to pgjdbc repo. Revertible after pgjdbc/pgjdbc#926
@codecov-io
Copy link

@codecov-io codecov-io commented Aug 27, 2017

Codecov Report

Merging #926 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #926      +/-   ##
============================================
+ Coverage     65.83%   65.85%   +0.01%     
- Complexity     3545     3547       +2     
============================================
  Files           166      166              
  Lines         15233    15233              
  Branches       2470     2470              
============================================
+ Hits          10028    10031       +3     
+ Misses         4026     4025       -1     
+ Partials       1179     1177       -2

Loading

voidfist added a commit to voidfist/checkstyle that referenced this issue Aug 27, 2017
…ut quotes in '@see' tag. Updated 'wercker.yml' to apply a patch to pgjdbc repo. Revertible after pgjdbc/pgjdbc#926
@davecramer davecramer merged commit 29f574a into pgjdbc:master Aug 28, 2017
2 checks passed
Loading
davecramer added a commit to davecramer/pgjdbc that referenced this issue Sep 19, 2017
rhavermans added a commit to bolcom/pgjdbc that referenced this issue Jul 13, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this issue Jul 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants