Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use mainly trusty in Travis and reorder jobs and jdk tests #939

Merged
merged 8 commits into from Sep 19, 2017

Conversation

@jorsol
Copy link
Member

@jorsol jorsol commented Sep 7, 2017

Travis is in the process of phasing out dist: precise since it's EOL, so this update make Trusty the default and use dist: precise only where is required, read PostgreSQL 8.3 and PostgreSQL 8.2. And based on the calendars provided by Travis, precise will be supported until March 2018, after that, we will no longer be able to test Pg 8.2 and 8.3.

This also updates openjdk6 and openjdk7 to use the Zulu OpenJDK, since they are better supported and maintained than the ones integrated in Travis, it looks the openjdk6 is faulty in precise and openjdk7 is slower in Trusty. And since openjdk6 is not available in Trusty, it make sense to use Zulu instead. On the other hand the JDK9 uses the oracle version instead of the zulu (the container-based is a little faster than the fully-virtualized one).

Another change here is to test primary over Pg 9.6 (previously was Pg 9.4) and reorder the jobs based on versions.

@codecov-io
Copy link

@codecov-io codecov-io commented Sep 7, 2017

Codecov Report

Merging #939 into master will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #939      +/-   ##
============================================
+ Coverage     65.85%   65.91%   +0.06%     
- Complexity     3547     3559      +12     
============================================
  Files           166      166              
  Lines         15233    15223      -10     
  Branches       2470     2458      -12     
============================================
+ Hits          10032    10035       +3     
+ Misses         4024     4022       -2     
+ Partials       1177     1166      -11

@jorsol
Copy link
Member Author

@jorsol jorsol commented Sep 7, 2017

It works! and take less time 😄

@jorsol
Copy link
Member Author

@jorsol jorsol commented Sep 8, 2017

Any comments about this?

@vlsi
Copy link
Member

@vlsi vlsi commented Sep 18, 2017

take less time

It looks like the PR reduces the number of jobs from 19 to 18.
Was that intended? Which job was removed?

As JDK6/7 are sorted to the end of the queue, JDK7-related issues would be hard to

Number of "COVERAGE=Y" jobs should match with codecov configuration (see https://github.com/pgjdbc/pgjdbc/blob/master/codecov.yml#L3 ). At least I think it should be aligned for proper "coverage diff" display.

Could you align that?

- oracle-java8-installer
sudo: required
dist: trusty
- oracle-java8-installer # Test with latest update
Copy link
Member

@vlsi vlsi Sep 18, 2017

That is an interesting move.

Would you add an environment variable so one can "ctrl+f" Travis results page and tell which is "plain Java8" and which is "Java8 with updates"?

.travis.yml Outdated
- sudo apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 0x219BD9C9
- sudo apt-add-repository 'deb http://repos.azulsystems.com/ubuntu stable main'
- sudo apt-get update -qq && sudo apt-get install zulu-8 -y
- export JDK8_HOME=/usr/lib/jvm/zulu-8-amd64
Copy link
Member

@vlsi vlsi Sep 18, 2017

Travis results would read "oraclejdk8", however it would use Zulu8. Would you add an environment variable to tell the difference?

vlsi
Copy link
Member

vlsi commented on 061a196 Sep 18, 2017

Is it different from single export JDK${ZULU_JDK}_HOME=/usr/lib/jvm/zulu-$ZULU_JDK-amd64 command?

@jorsol
Copy link
Member Author

@jorsol jorsol commented Sep 19, 2017

@vlsi changes done:

  • Simplify installation of zulu jdk using enviromental variable with an installation script.
  • Add a env variable LATEST_JAVA_UPDATE for the java 8 update, this is actually not really needed since Travis updates JDK images from time to time and the variable is not used at all.
  • Align coverage jobs, check jobs that actually can produce diff.

The job removed is actually a merge/duplicate/reorganization of openjdk6 and openjdk7.

@davecramer
Copy link
Member

@davecramer davecramer commented Sep 19, 2017

@vlsi can we push this ?

vlsi
vlsi approved these changes Sep 19, 2017
@vlsi vlsi added this to the 42.1.5 milestone Sep 19, 2017
@vlsi vlsi merged commit 646a868 into pgjdbc:master Sep 19, 2017
2 checks passed
@vlsi
Copy link
Member

@vlsi vlsi commented Sep 19, 2017

@jorsol , thanks for looking into this. I'm really looking forward for streamlining CI jobs and sensible coverage diffs.

@jorsol
Copy link
Member Author

@jorsol jorsol commented Sep 19, 2017

@vlsi your welcome, I'm exploring some others ideas as well, I'm adding ideas to #938

@jorsol jorsol deleted the travis-trusty-zulu branch Sep 22, 2017
@vlsi vlsi removed this from the 42.1.5 milestone Jan 8, 2018
@vlsi vlsi added this to the 42.2.0 milestone Jan 8, 2018
rhavermans added a commit to bolcom/pgjdbc that referenced this issue Jul 13, 2018
…gjdbc#939)

Travis is in the process of phasing out `dist: precise`, so it is time to update CI job configuration.
rhavermans added a commit to bolcom/pgjdbc that referenced this issue Jul 13, 2018
…gjdbc#939)

Travis is in the process of phasing out `dist: precise`, so it is time to update CI job configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants